Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1455883003: bindings: Pass dictionaries to callback methods by const reference (Closed)

Created:
5 years, 1 month ago by shalamov
Modified:
5 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Pass dictionaries to callback methods by const reference Before this CL, strings and container types were passed to callback method by const reference. Dictionary types should also be passed by const ref to avoid unnecessary copying. BUG=557590 Committed: https://crrev.com/02b9d4670fc8e06145343d19ea3e2ea28c7069f8 Cr-Commit-Position: refs/heads/master@{#360549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
shalamov
I'm implementing WebNFC API (crrev.com/1444303002) and I found out that V8 binding generator passes dictionaries ...
5 years, 1 month ago (2015-11-18 11:21:44 UTC) #3
haraken
On 2015/11/18 11:21:44, shalamov wrote: > I'm implementing WebNFC API (crrev.com/1444303002) and I found out ...
5 years, 1 month ago (2015-11-18 11:32:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455883003/1
5 years, 1 month ago (2015-11-18 11:39:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142407)
5 years, 1 month ago (2015-11-18 12:26:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455883003/1
5 years, 1 month ago (2015-11-19 09:47:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 10:37:54 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 10:39:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02b9d4670fc8e06145343d19ea3e2ea28c7069f8
Cr-Commit-Position: refs/heads/master@{#360549}

Powered by Google App Engine
This is Rietveld 408576698