Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1455863003: Implement support for generic methods in summaries. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement support for generic methods in summaries. In theory generic top level functions are also supported, but they aren't tested due to lack of parser support. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0aebd7d6b20c9f7d79f0233dcd9ab10b0f1aaa9a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -29 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 9 chunks +38 lines, -27 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 6 chunks +57 lines, -1 line 1 comment Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
5 years, 1 month ago (2015-11-18 00:03:10 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1455863003/diff/1/pkg/analyzer/test/src/summary/summary_test.dart File pkg/analyzer/test/src/summary/summary_test.dart (right): https://codereview.chromium.org/1455863003/diff/1/pkg/analyzer/test/src/summary/summary_test.dart#newcode1263 pkg/analyzer/test/src/summary/summary_test.dart:1263: // TODO(paulberry): also test top level executables. Alternately, ...
5 years, 1 month ago (2015-11-18 00:12:09 UTC) #4
scheglov
LGTM
5 years, 1 month ago (2015-11-18 00:26:10 UTC) #5
Paul Berry
5 years, 1 month ago (2015-11-18 18:26:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0aebd7d6b20c9f7d79f0233dcd9ab10b0f1aaa9a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698