Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: mojo/services/test_service/test_service_impl.cc

Issue 1455833005: Convert ConnectToApplication to take a params class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/network/udp_socket_apptest.cc ('k') | mojo/services/test_service/test_time_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/test_service/test_service_impl.cc
diff --git a/mojo/services/test_service/test_service_impl.cc b/mojo/services/test_service/test_service_impl.cc
index 44d1818d8d9c0784bf6d00832a70ad14a0508fe4..1f467e50e2ab41b5bb202338c05b898c0dc58e8f 100644
--- a/mojo/services/test_service/test_service_impl.cc
+++ b/mojo/services/test_service/test_service_impl.cc
@@ -43,9 +43,7 @@ void SendTimeResponse(
void TestServiceImpl::ConnectToAppAndGetTime(
const mojo::String& app_url,
const mojo::Callback<void(int64_t)>& callback) {
- mojo::URLRequestPtr request(mojo::URLRequest::New());
- request->url = mojo::String::From(app_url);
- app_impl_->ConnectToService(request.Pass(), &time_service_);
+ app_impl_->ConnectToService(app_url.get(), &time_service_);
if (tracking_) {
tracking_->RecordNewRequest();
time_service_->StartTrackingRequests(mojo::Callback<void()>());
@@ -56,9 +54,7 @@ void TestServiceImpl::ConnectToAppAndGetTime(
void TestServiceImpl::StartTrackingRequests(
const mojo::Callback<void()>& callback) {
TestRequestTrackerPtr tracker;
- mojo::URLRequestPtr request(mojo::URLRequest::New());
- request->url = mojo::String::From("mojo:test_request_tracker_app");
- app_impl_->ConnectToService(request.Pass(), &tracker);
+ app_impl_->ConnectToService("mojo:test_request_tracker_app", &tracker);
tracking_.reset(new TrackedService(tracker.Pass(), Name_, callback));
}
« no previous file with comments | « mojo/services/network/udp_socket_apptest.cc ('k') | mojo/services/test_service/test_time_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698