Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: test/unittests/compiler/linkage-tail-call-unittest.cc

Issue 1455833004: [turbofan]: Implement tail calls with more callee than caller parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Improve comment Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/linkage-tail-call-unittest.cc
diff --git a/test/unittests/compiler/linkage-tail-call-unittest.cc b/test/unittests/compiler/linkage-tail-call-unittest.cc
index 814f5efb8e684cd68a25b7a2ef6afa7fae19bb6e..255c8a1150f63a13cb2e91c32215632733ee7f75 100644
--- a/test/unittests/compiler/linkage-tail-call-unittest.cc
+++ b/test/unittests/compiler/linkage-tail-call-unittest.cc
@@ -157,8 +157,8 @@ TEST_F(LinkageTailCall, MoreRegisterAndStackParametersCallee) {
const Operator* op = common.Call(desc2);
Node* const node = Node::New(zone(), 1, op, 0, nullptr, false);
int stack_param_delta = 0;
- EXPECT_FALSE(desc1->CanTailCall(node, &stack_param_delta));
- EXPECT_EQ(1, stack_param_delta);
+ EXPECT_TRUE(desc1->CanTailCall(node, &stack_param_delta));
+ EXPECT_EQ(-1, stack_param_delta);
}
@@ -179,7 +179,7 @@ TEST_F(LinkageTailCall, MoreRegisterAndStackParametersCaller) {
Node* const node = Node::New(zone(), 1, op, 0, nullptr, false);
int stack_param_delta = 0;
EXPECT_TRUE(desc1->CanTailCall(node, &stack_param_delta));
- EXPECT_EQ(-1, stack_param_delta);
+ EXPECT_EQ(1, stack_param_delta);
}
@@ -314,7 +314,7 @@ TEST_F(LinkageTailCall, MatchingStackParametersExtraCallerRegistersAndStack) {
Node::New(zone(), 1, op, arraysize(parameters), parameters, false);
int stack_param_delta = 0;
EXPECT_TRUE(desc1->CanTailCall(node, &stack_param_delta));
- EXPECT_EQ(-1, stack_param_delta);
+ EXPECT_EQ(1, stack_param_delta);
}
@@ -341,8 +341,8 @@ TEST_F(LinkageTailCall, MatchingStackParametersExtraCalleeRegistersAndStack) {
Node* const node =
Node::New(zone(), 1, op, arraysize(parameters), parameters, false);
int stack_param_delta = 0;
- EXPECT_FALSE(desc1->CanTailCall(node, &stack_param_delta));
- EXPECT_EQ(1, stack_param_delta);
+ EXPECT_TRUE(desc1->CanTailCall(node, &stack_param_delta));
+ EXPECT_EQ(-1, stack_param_delta);
}
} // namespace compiler
« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698