Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.h

Issue 145583005: [SVG] Remove existing event listeners when eventBase conditions are cleared (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaselined and worked on review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 123
124 void setInactive() { m_activeState = Inactive; } 124 void setInactive() { m_activeState = Inactive; }
125 125
126 // Sub-classes may need to take action when the target is changed. 126 // Sub-classes may need to take action when the target is changed.
127 virtual void setTargetElement(SVGElement*); 127 virtual void setTargetElement(SVGElement*);
128 virtual void setAttributeName(const QualifiedName&); 128 virtual void setAttributeName(const QualifiedName&);
129 129
130 private: 130 private:
131 virtual void buildPendingResource() OVERRIDE; 131 virtual void buildPendingResource() OVERRIDE;
132 void clearResourceAndEventBaseReferences(); 132 void clearResourceAndEventBaseReferences();
133 void clearConditions();
133 134
134 virtual void startedActiveInterval() = 0; 135 virtual void startedActiveInterval() = 0;
135 void endedActiveInterval(); 136 void endedActiveInterval();
136 virtual void updateAnimation(float percent, unsigned repeat, SVGSMILElement* resultElement) = 0; 137 virtual void updateAnimation(float percent, unsigned repeat, SVGSMILElement* resultElement) = 0;
137 138
138 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; } 139 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; }
139 140
140 enum BeginOrEnd { 141 enum BeginOrEnd {
141 Begin, 142 Begin,
142 End 143 End
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 { 244 {
244 return node.hasTagName(SVGNames::setTag) || node.hasTagName(SVGNames::animat eTag) || node.hasTagName(SVGNames::animateMotionTag) 245 return node.hasTagName(SVGNames::setTag) || node.hasTagName(SVGNames::animat eTag) || node.hasTagName(SVGNames::animateMotionTag)
245 || node.hasTagName(SVGNames::animateTransformTag) || node.hasTagName((SV GNames::discardTag)); 246 || node.hasTagName(SVGNames::animateTransformTag) || node.hasTagName((SV GNames::discardTag));
246 } 247 }
247 248
248 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(SVGSMILElement); 249 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(SVGSMILElement);
249 250
250 } 251 }
251 252
252 #endif // SVGSMILElement_h 253 #endif // SVGSMILElement_h
OLDNEW
« no previous file with comments | « LayoutTests/svg/animations/remove-begin-event-crash-expected.txt ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698