LayoutTests/svg/animations/remove-begin-event-crash.html - Issue 145583005: [SVG] Remove existing event listeners when eventBase conditions are cleared

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/animations/remove-begin-event-crash.html

Issue 145583005: [SVG] Remove existing event listeners when eventBase conditions are cleared (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html onload="tCFcrash();">
	Stephen Chennney 2014/01/27 15:24:28 Rename methods and variables to something meaningf Rename methods and variables to something meaningful. pavane 2014/01/27 17:01:19 Done. Show quoted text On 2014/01/27 15:24:28, Stephen Chenney wrote: > Rename methods and variables to something meaningful. Done.
	3 <head>

	4 <script>

	5 function tCFcrash() {

	6 tCF4.removeAttribute("begin");

	7 tCF4.parentNode.removeChild(tCF4);

	8 delete tCF4;

	9 }

	10 if (window.testRunner)

	11 testRunner.dumpAsText();

	12 </script>

	13 </head>

	14 <body>

	15 Test for crbug.com/338124: This test passes if it does not crash.<br/>
	Stephen Chennney 2014/01/27 15:24:28 We generally do not reference the bug in the test We generally do not reference the bug in the test description. You should be able to describe the issue it is testing. In this case "Test that event listeners are correctly removed when eventBase conditions are cleared." pavane 2014/01/27 17:01:19 Done. Show quoted text On 2014/01/27 15:24:28, Stephen Chenney wrote: > We generally do not reference the bug in the test description. You should be > able to describe the issue it is testing. In this case "Test that event > listeners are correctly removed when eventBase conditions are cleared." Done.
	16 PASS

	17 <svg>

	18 <animate id="anim" attributeName="visibility" />

	19 <set begin="anim.beginEvent" id="tCF4" to="100" attributeName="width" />

	20 </svg>

	21 </body>

	22 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/animations/remove-begin-event-crash-expected.txt » ('j') | Source/core/svg/animation/SVGSMILElement.cpp » ('J')