Issue 145583004: A64: Fix sampling of fp register for CPU profile and bailout if sp or fp is zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145583004: A64: Fix sampling of fp register for CPU profile and bailout if sp or fp is zero. (Closed)

Created:
6 years, 11 months ago by ulan

Modified:
6 years, 11 months ago

Reviewers:
baptiste.afsa1, jbramley

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

A64: Fix sampling of fp register for CPU profile and bailout if sp or fp is zero. TEST=cctest/test-cpu-profiler R=jacob.bramley@arm.com Committed: https://code.google.com/p/v8/source/detail?r=18849

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/a64/simulator-a64.h	View		1 chunk	+1 line, -0 lines	2 comments	Download
	M	src/sampler.cc	View		2 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jbramley

lgtm https://codereview.chromium.org/145583004/diff/1/src/a64/simulator-a64.h File src/a64/simulator-a64.h (right): https://codereview.chromium.org/145583004/diff/1/src/a64/simulator-a64.h#newcode443 src/a64/simulator-a64.h:443: inline int64_t fp() { return xreg(29, Reg31IsStackPointer); } ...

6 years, 11 months ago (2014-01-27 10:40:21 UTC) #2

ulan

Committed patchset #1 manually as r18849 (tree was closed).

6 years, 11 months ago (2014-01-27 10:54:18 UTC) #3

ulan

6 years, 11 months ago (2014-01-27 10:55:06 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/145583004/diff/1/src/a64/simulator-a64.h
File src/a64/simulator-a64.h (right):

https://codereview.chromium.org/145583004/diff/1/src/a64/simulator-a64.h#newc...
src/a64/simulator-a64.h:443: inline int64_t fp() { return xreg(29,
Reg31IsStackPointer); }
On 2014/01/27 10:40:21, jbramley wrote:
> We have a kFramePointerRegCode.

Done.

Expand Messages | Collapse Messages