Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 145583004: A64: Fix sampling of fp register for CPU profile and bailout if sp or fp is zero. (Closed)

Created:
6 years, 11 months ago by ulan
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Fix sampling of fp register for CPU profile and bailout if sp or fp is zero. TEST=cctest/test-cpu-profiler R=jacob.bramley@arm.com Committed: https://code.google.com/p/v8/source/detail?r=18849

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/a64/simulator-a64.h View 1 chunk +1 line, -0 lines 2 comments Download
M src/sampler.cc View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL, this fixes the cpu-profiler failures.
6 years, 11 months ago (2014-01-27 09:27:48 UTC) #1
jbramley
lgtm https://codereview.chromium.org/145583004/diff/1/src/a64/simulator-a64.h File src/a64/simulator-a64.h (right): https://codereview.chromium.org/145583004/diff/1/src/a64/simulator-a64.h#newcode443 src/a64/simulator-a64.h:443: inline int64_t fp() { return xreg(29, Reg31IsStackPointer); } ...
6 years, 11 months ago (2014-01-27 10:40:21 UTC) #2
ulan
Committed patchset #1 manually as r18849 (tree was closed).
6 years, 11 months ago (2014-01-27 10:54:18 UTC) #3
ulan
6 years, 11 months ago (2014-01-27 10:55:06 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/145583004/diff/1/src/a64/simulator-a64.h
File src/a64/simulator-a64.h (right):

https://codereview.chromium.org/145583004/diff/1/src/a64/simulator-a64.h#newc...
src/a64/simulator-a64.h:443: inline int64_t fp() { return xreg(29,
Reg31IsStackPointer); }
On 2014/01/27 10:40:21, jbramley wrote:
> We have a kFramePointerRegCode.

Done.

Powered by Google App Engine
This is Rietveld 408576698