Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 145583003: Revert "Allow arbitrary names for weak references in heap snapshots." (Closed)

Created:
6 years, 11 months ago by Benedikt Meurer
Modified:
6 years, 11 months ago
Reviewers:
alph
CC:
v8-dev
Visibility:
Public.

Description

Revert "Allow arbitrary names for weak references in heap snapshots." This reverts commit r18838 for breaking build with clang. Errors are: ../../src/heap-snapshot-generator.cc:1217:53: error: empty macro arguments were standardized in C99 [-Werror,-pedantic] EXTRACT_CONTEXT_FIELD(OPTIMIZED_FUNCTIONS_LIST, , optimized_functions_list); ../../src/heap-snapshot-generator.cc:1218:48: error: empty macro arguments were standardized in C99 [-Werror,-pedantic] EXTRACT_CONTEXT_FIELD(OPTIMIZED_CODE_LIST, , optimized_code_list); ../../src/heap-snapshot-generator.cc:1219:50: error: empty macro arguments were standardized in C99 [-Werror,-pedantic] EXTRACT_CONTEXT_FIELD(DEOPTIMIZED_CODE_LIST, , deoptimized_code_list); ../../src/heap-snapshot-generator.cc:1220:46: error: empty macro arguments were standardized in C99 [-Werror,-pedantic] EXTRACT_CONTEXT_FIELD(NEXT_CONTEXT_LINK, , next_context_link); TBR=alph@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -53 lines) Patch
src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
src/heap-snapshot-generator.h View 2 chunks +3 lines, -4 lines 0 comments Download
src/heap-snapshot-generator.cc View 11 chunks +30 lines, -47 lines 0 comments Download
test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
6 years, 11 months ago (2014-01-27 06:47:31 UTC) #1
Benedikt Meurer
6 years, 11 months ago (2014-01-27 06:47:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r18844 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698