ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java - Issue 1455793005: Adding a way to associate Android Activities with PlatformWindowAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java

Issue 1455793005: Adding a way to associate Android Activities with PlatformWindowAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_native_widget

Patch Set: Addressing feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/aura/window_tree_host_platform.cc ('k') | ui/platform_window/android/platform_window_android.h » ('j') | ui/platform_window/android/platform_window_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java

diff --git a/ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java b/ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java

index 9c77fce65121c5d8513a3da562444f5a40ff429f..df4f1e0fba21329cb2fbc3cd4643c82a26496221 100644

--- a/ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java

+++ b/ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java

@@ -31,10 +31,10 @@ public class PlatformWindowAndroid extends SurfaceView {

@CalledByNative

public static PlatformWindowAndroid createForActivity(

Activity activity, long nativeViewport, long nativeImeController) {

- PlatformWindowAndroid rv =

+ PlatformWindowAndroid pwa =

new PlatformWindowAndroid(activity, nativeViewport, nativeImeController);

- activity.setContentView(rv);

- return rv;

+ activity.setContentView(pwa);

+ return pwa;

}

public PlatformWindowAndroid(Context context, long nativeViewport, long nativeImeController) {