Adding a way to associate Android Activities with PlatformWindowAndroid

ui/aura/window_tree_host_platform.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window_tree_host_platform.h"
 
 #include "base/trace_event/trace_event.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/compositor/compositor.h"
 #include "ui/events/event.h"
 #include "ui/gfx/screen.h"
 
 #if defined(OS_ANDROID)
+#include "ui/aura/client/aura_constants.h"
 #include "ui/platform_window/android/platform_window_android.h"
 #endif
 
 #if defined(USE_OZONE)
 #include "ui/ozone/public/ozone_platform.h"
 #endif
 
 #if defined(OS_WIN)
 #include "base/message_loop/message_loop.h"
 #include "ui/base/cursor/cursor_loader_win.h"
@@ skipping 40 matching lines @@
 
 ui::EventSource* WindowTreeHostPlatform::GetEventSource() {
   return this;
 }
 
 gfx::AcceleratedWidget WindowTreeHostPlatform::GetAcceleratedWidget() {
   return widget_;
 }
 
 void WindowTreeHostPlatform::ShowImpl() {
+#if defined(OS_ANDROID)
+  JNIEnv* env = base::android::AttachCurrentThread();
+  jobject activity = window()->GetProperty(
+      aura::client::kActivityForRootWindow);
+  ui::PlatformWindowAndroid::createForActivity(
+      env,
+      activity,
+      reinterpret_cast<jlong>(window_.get()),
+      reinterpret_cast<jlong>(window_->GetPlatformImeController()));

[sadrul, 2015/11/25 20:59:44]

Curious as to the signature of this function ... why not
PlatformWindowAndroid::AttachToActivity(activity) instead?

[mfomitchev, 2015/11/27 20:57:15]

Done.

+#endif

[sadrul, 2015/11/25 20:59:44]

We shouldn't do this for every call to ::ShowImpl(), just the first one. Right?

If you think there will be additional android-specific changes in
WindowTreeHostPlatform, then it might make sense to have a separate
WindowTreeHostAndroid subclass from WTHPlatform and override ShowImpl().

[mfomitchev, 2015/11/27 20:57:15]

Oops, yes, forgot to fix this, thanks. Done.
I played with creating a new class but we either need to have WTHA duplicate a
bunch of code WTHP, or have a new common abstract superclass for WTHA and
WTHWinOzone, or have some Android ifdefs in WTHP (in addition to WTHA) and I
think the current approach is better than these alternatives.

   window_->Show();
 }
 
 void WindowTreeHostPlatform::HideImpl() {
   window_->Hide();
 }
 
 gfx::Rect WindowTreeHostPlatform::GetBounds() const {
   return window_->GetBounds();
 }
@@ skipping 99 matching lines @@
   DCHECK_EQ(widget, widget_);
   widget_ = gfx::kNullAcceleratedWidget;
 }
 
 void WindowTreeHostPlatform::OnActivationChanged(bool active) {
   if (active)
     OnHostActivated();
 }
 
 }  // namespace aura