Use union type in ImageBitmapFactories.idl

third_party/WebKit/Source/core/imagebitmap/ImageBitmapSource.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ImageBitmapSource_h
+#define ImageBitmapSource_h
+
+#include "bindings/core/v8/ScriptPromise.h"
+#include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "bindings/core/v8/ScriptState.h"
+#include "core/CoreExport.h"
+#include "core/dom/ExceptionCode.h"
+#include "platform/geometry/IntSize.h"
+
+namespace blink {
+
+class ImageBitmap;
+
+class CORE_EXPORT ImageBitmapSource {
+public:
+    virtual IntSize bitmapSourceSize() { return IntSize(); }
+    virtual PassRefPtrWillBeRawPtr<ImageBitmap> createImageBitmap(EventTarget&, ImageBitmapSource*, int sx, int sy, int sw, int sh, ExceptionState&) { return nullptr; }

[davve, 2015/11/27 11:19:43]

Drive-by review: Why do you pass ImageBitmapSource* here? Won't the this pointer
do? The static_cast inside the non-static createImageBitmap implementations
looks a bit off.

[xidachen, 2015/11/27 19:00:25]

Great comments! I remove this parameter and there should be no static_cast in
the derived class now. Let me know when you spot one. Thanks.

+
+    virtual bool isBlob() const { return false; }
+
+protected:
+    virtual ~ImageBitmapSource() {}
+};
+
+} // namespace blink
+
+#endif