Source/core/loader/ResourceLoaderOptions.h - Issue 14557011: Fix problems with cross-origin redirects.

Side by Side Diff: Source/core/loader/ResourceLoaderOptions.h

Issue 14557011: Fix problems with cross-origin redirects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/loader/DocumentThreadableLoader.cpp ('K') | « Source/core/loader/DocumentThreadableLoader.cpp ('k') | Source/core/loader/cache/CachedResourceLoader.cpp » ('j') | Source/core/platform/network/ResourceHandleTypes.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 AskClientForCrossOriginCredentials,	54 AskClientForCrossOriginCredentials,

55 DoNotAskClientForCrossOriginCredentials	55 DoNotAskClientForCrossOriginCredentials

56 };	56 };

57	57

58 enum SecurityCheckPolicy {	58 enum SecurityCheckPolicy {

59 SkipSecurityCheck,	59 SkipSecurityCheck,

60 DoSecurityCheck	60 DoSecurityCheck

61 };	61 };

62	62

63 struct ResourceLoaderOptions {	63 struct ResourceLoaderOptions {

64 ResourceLoaderOptions() : sendLoadCallbacks(DoNotSendCallbacks), sniffConten t(DoNotSniffContent), dataBufferingPolicy(BufferData), allowCredentials(DoNotAll owStoredCredentials), crossOriginCredentialPolicy(DoNotAskClientForCrossOriginCr edentials), securityCheck(DoSecurityCheck) { }	64 ResourceLoaderOptions() : sendLoadCallbacks(DoNotSendCallbacks), sniffConten t(DoNotSniffContent), dataBufferingPolicy(BufferData), allowCredentials(DoNotAll owStoredCredentials), credentialsRequested(ClientDidNotRequestCredentials), cros sOriginCredentialPolicy(DoNotAskClientForCrossOriginCredentials), securityCheck( DoSecurityCheck) { }
	abarth-chromium 2013/05/09 04:22:06 Can you explode this onto a bunch of lines so that Can you explode this onto a bunch of lines so that it's easier to read? Ken Russell (switch to Gerrit) 2013/05/09 23:50:02 Will do. Show quoted text On 2013/05/09 04:22:06, abarth wrote: > Can you explode this onto a bunch of lines so that it's easier to read? Will do.
65 ResourceLoaderOptions(SendCallbackPolicy sendLoadCallbacks, ContentSniffingP olicy sniffContent, DataBufferingPolicy dataBufferingPolicy, StoredCredentials a llowCredentials, ClientCrossOriginCredentialPolicy crossOriginCredentialPolicy, SecurityCheckPolicy securityCheck)	65 ResourceLoaderOptions(SendCallbackPolicy sendLoadCallbacks, ContentSniffingP olicy sniffContent, DataBufferingPolicy dataBufferingPolicy, StoredCredentials a llowCredentials, CredentialRequest credentialsRequested, ClientCrossOriginCreden tialPolicy crossOriginCredentialPolicy, SecurityCheckPolicy securityCheck)

66 : sendLoadCallbacks(sendLoadCallbacks)	66 : sendLoadCallbacks(sendLoadCallbacks)

67 , sniffContent(sniffContent)	67 , sniffContent(sniffContent)

68 , dataBufferingPolicy(dataBufferingPolicy)	68 , dataBufferingPolicy(dataBufferingPolicy)

69 , allowCredentials(allowCredentials)	69 , allowCredentials(allowCredentials)

	70 , credentialsRequested(credentialsRequested)

70 , crossOriginCredentialPolicy(crossOriginCredentialPolicy)	71 , crossOriginCredentialPolicy(crossOriginCredentialPolicy)

71 , securityCheck(securityCheck)	72 , securityCheck(securityCheck)

72 {	73 {

73 }	74 }

74 SendCallbackPolicy sendLoadCallbacks;	75 SendCallbackPolicy sendLoadCallbacks;

75 ContentSniffingPolicy sniffContent;	76 ContentSniffingPolicy sniffContent;

76 DataBufferingPolicy dataBufferingPolicy;	77 DataBufferingPolicy dataBufferingPolicy;

77 StoredCredentials allowCredentials; // Whether HTTP credentials and cookies are sent with the request.	78 StoredCredentials allowCredentials; // Whether HTTP credentials and cookies are sent with the request.

	79 CredentialRequest credentialsRequested; // Whether the client (e.g. XHR) wan ted credentials in the first place.
	abarth-chromium 2013/05/09 04:22:06 It's confusing to have these two closely related f It's confusing to have these two closely related fields. Can we add more values to the StoredCredentials enum to cover these cases?
78 ClientCrossOriginCredentialPolicy crossOriginCredentialPolicy; // Whether we will ask the client for credentials (if we allow credentials at all).	80 ClientCrossOriginCredentialPolicy crossOriginCredentialPolicy; // Whether we will ask the client for credentials (if we allow credentials at all).

79 SecurityCheckPolicy securityCheck;	81 SecurityCheckPolicy securityCheck;

80 };	82 };

81	83

82 } // namespace WebCore	84 } // namespace WebCore

83	85

84 #endif // ResourceLoaderOptions_h	86 #endif // ResourceLoaderOptions_h

OLD	NEW