Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1455693007: Add cookie prefix metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/cookies/canonical_cookie_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index c8816c3a67a6bb0d57cca583d425b05cfc3276c4..df0dc763b8a41c805a98c29db1fb40be29a16c35 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -5229,6 +5229,28 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Intervals between access time updates for each cookie.</summary>
</histogram>
+<histogram name="Cookie.CookiePrefix" enum="CookiePrefix">
+ <owner>estark@chromium.org</owner>
+ <summary>
+ Number of times a cookie was set with a name prefixed by
+ &quot;$Secure-&quot; or &quot;$Host-&quot; (prefixes reserved by
+ https://tools.ietf.org/html/draft-west-cookie-prefixes).
+ </summary>
+</histogram>
+
+<histogram name="Cookie.CookiePrefixBlocked" enum="CookiePrefix">
+ <owner>estark@chromium.org</owner>
+ <summary>
+ Number of times a cookie was set with a name prefixed by
+ &quot;$Secure-&quot; or &quot;$Host-&quot; that violate cookie prefix rules.
+ That is, a $Secure- cookie must be set over a secure connection with the
+ Secure attribute, and a $Host- cookie must be set over a secure connection,
+ with the Secure attribute, with no Domain attribute, and with a Path
+ attribute of &quot;/&quot;. (As defined in
+ https://tools.ietf.org/html/draft-west-cookie-prefixes.)
+ </summary>
+</histogram>
+
<histogram name="Cookie.CookieSourceScheme" enum="CookieSourceScheme">
<owner>estark@chromium.org</owner>
<summary>
@@ -56750,6 +56772,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="3" label="Both"/>
</enum>
+<enum name="CookiePrefix" type="int">
+ <int value="0" label="No special prefix"/>
+ <int value="1" label="Secure prefix"/>
+ <int value="2" label="Host prefix"/>
+</enum>
+
<enum name="CookieSourceScheme" type="int">
<int value="0" label="Secure cookie, source scheme is cryptographic"/>
<int value="1" label="Secure cookie, source scheme is not cryptographic"/>
« no previous file with comments | « net/cookies/canonical_cookie_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698