Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 1455693002: Add summary tests for cascaded show/hide combinators. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add summary tests for cascaded show/hide combinators. At the moment these tests are mostly redundant, since the semantics of cascaded combinators are implemented elsewhere. However, when we add a relinking mechanism these tests will ensure that cascaded combinator semantics are properly implemented by the relinker. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/55983428b440fbdb4d434e3cbf675367b82b454e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -0 lines) Patch
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +128 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 1 month ago (2015-11-17 18:31:15 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-17 18:37:32 UTC) #3
Paul Berry
5 years, 1 month ago (2015-11-17 22:02:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55983428b440fbdb4d434e3cbf675367b82b454e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698