Add UseCounter for border-image overriding border-widths

Add UseCounter for border-image overriding border-widths

According to the specification, if one border-style is 'none' the
corresponding border-width should be zero and thus border-image-width
resolve to zero. No border-image can be drawn at zero-width border.

WebKit implemented an old version of the css border specification for
border-image and does not reset border-widths to zero for border-style
'none' when there is a border-image.

Add a use counter to get data on how many views that rely on this
behavior.

BUG=356802
Committed: https://crrev.com/235538d4c5836ab7651ae54ce04360eca362089d
Cr-Commit-Position: refs/heads/master@{#360357}

[davve, 2015-11-17 17:07:15]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 17:08:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455673002/1

[commit-bot: I haz the power, 2015-11-17 18:19:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 18:19:37]

Dry run: This issue passed the CQ dry run.

[davve, 2015-11-18 07:21:21]

davve@opera.com changed reviewers:
+ alancutter@chromium.org, philipj@opera.com

[davve, 2015-11-18 07:21:21]

Alan, having some data seemed like the first step to taking any sort of action
on bug 356802. Do you agree?

[alancutter (OOO until 2018), 2015-11-18 08:22:23]

On 2015/11/18 at 07:21:21, davve wrote:
> Alan, having some data seemed like the first step to taking any sort of action
on bug 356802. Do you agree?

I don't think data is necessary to change behaviour here given that Firefox and
IE already behave differently. That being said I have nothing against collecting
data, lgtm.

[philipj_slow, 2015-11-18 09:28:59]

lgtm

https://codereview.chromium.org/1455673002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp (right):

https://codereview.chromium.org/1455673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp:39: if
((style.borderLeftWidth() && style.borderLeft().style() == BNONE)
Comment that these conditions are meant to isolate whether the
!m_image.hasImage() part of borderLeftWidth() had any effect, as that's the only
way that border-style:none does not imply border-width:0.

Also, should BHIDDEN be included here?

[davve, 2015-11-18 10:54:55]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-18 10:55:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455673002/20001

[davve, 2015-11-18 10:56:50]

On 2015/11/18 08:22:23, alancutter wrote:
> I don't think data is necessary to change behaviour here given that Firefox
and
> IE already behave differently.

It seems like Edge has moved closer to Blink/WebKit in this case. I mailed MS
asking why (you have been cc:ed).

[commit-bot: I haz the power, 2015-11-18 11:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 11:21:19]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[davve, 2015-11-18 12:59:08]

The CQ bit was checked by davve@opera.com

[davve, 2015-11-18 12:59:08]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1455673002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2015-11-18 12:59:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455673002/20001

[commit-bot: I haz the power, 2015-11-18 14:02:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 14:02:16]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davve, 2015-11-18 15:46:08]

The CQ bit was checked by davve@opera.com

[davve, 2015-11-18 15:46:09]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1455673002/#ps40001
(title: "Fix c&p error")

[commit-bot: I haz the power, 2015-11-18 15:47:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455673002/40001

[commit-bot: I haz the power, 2015-11-18 17:41:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-18 17:42:36]

Patchset 3 (id:??) landed as
https://crrev.com/235538d4c5836ab7651ae54ce04360eca362089d
Cr-Commit-Position: refs/heads/master@{#360357}