Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 1455663002: PPC: [turbofan] Move JSCallFunction specialization to JSCallReducer. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Move JSCallFunction specialization to JSCallReducer. Port e5edd66d070952ad4243acf14aa7cc161be7fe18 Original commit message: This is the first part to refactoring the JSNativeContextSpecialization class, which has grown way too big recently. Also don't collect cross context feedback for the CallIC in general. Neither TurboFan nor Crankshaft can make any use of cross context JSFunction feedback that is collected by the CallIC, so there's no point in gathering that feedback at all (it just complicates the checking that is necessary in the compilers). What we should do instead at some point (when Crankshaft becomes less important) is to collect the SharedFunctionInfo as feedback for those cases. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4470 LOG=n Committed: https://crrev.com/5019ce6ef32f585a9304a9767358fbf52c3852fb Cr-Commit-Position: refs/heads/master@{#32059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-17 17:30:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455663002/1
5 years, 1 month ago (2015-11-17 17:49:06 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 18:06:42 UTC) #5
JoranSiu
On 2015/11/17 18:06:42, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 1 month ago (2015-11-17 19:40:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455663002/1
5 years, 1 month ago (2015-11-17 19:42:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 19:44:28 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 19:44:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5019ce6ef32f585a9304a9767358fbf52c3852fb
Cr-Commit-Position: refs/heads/master@{#32059}

Powered by Google App Engine
This is Rietveld 408576698