Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 14556020: Remove HLoadElements instruction and replace with use of more general HLoadNamedField. (Closed)

Created:
7 years, 7 months ago by titzer
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Remove HLoadElements instruction and replace with use of more general HLoadNamedField. This removes the need for both the hydrogen and lithium instructions and allows both kinds of loads to be GVN'd. Committed: https://code.google.com/p/v8/source/detail?r=14542

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -270 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 1 comment Download
M src/arm/lithium-arm.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +17 lines, -11 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -34 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
(Sorry for the new issue, I based the first issue off a mistaken commit to ...
7 years, 7 months ago (2013-05-03 10:52:10 UTC) #1
Michael Starzinger
LGTM with one nit. https://codereview.chromium.org/14556020/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/14556020/diff/1/.gitignore#newcode27 .gitignore:27: bsuite Obsolete change, let's drop ...
7 years, 7 months ago (2013-05-03 12:05:10 UTC) #2
titzer
7 years, 7 months ago (2013-05-03 12:21:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14542 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698