Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3456)

Unified Diff: chrome/browser/ui/webui/options/media_galleries_handler.h

Issue 14556015: [Media Galleries] Lazily initialize the storage monitor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Weak ptr for registry Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/media_galleries_handler.h
diff --git a/chrome/browser/ui/webui/options/media_galleries_handler.h b/chrome/browser/ui/webui/options/media_galleries_handler.h
index 441e7364ffafdd3507c013b7a3d72d0f6dfe0970..b76b20130d61ff822783b0f340581096e79747d9 100644
--- a/chrome/browser/ui/webui/options/media_galleries_handler.h
+++ b/chrome/browser/ui/webui/options/media_galleries_handler.h
@@ -6,11 +6,16 @@
#define CHROME_BROWSER_UI_WEBUI_OPTIONS_MEDIA_GALLERIES_HANDLER_H_
#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
#include "base/prefs/pref_change_registrar.h"
#include "chrome/browser/ui/webui/options/options_ui.h"
#include "content/public/browser/notification_observer.h"
#include "ui/shell_dialogs/select_file_dialog.h"
+namespace chrome {
+class MediaGalleriesPreferences;
+}
+
namespace options {
// Handles messages related to adding or removing media galleries.
@@ -36,14 +41,26 @@ class MediaGalleriesHandler : public OptionsPageUIHandler,
// Handles "forgetGallery" message. The first and only argument is the id of
// the gallery.
void HandleForgetGallery(const base::ListValue* args);
+ void HandleForgetGalleryWithPreferences(
Lei Zhang 2013/05/14 04:12:23 Can you comment FooWithPreferences() as the second
Greg Billock 2013/05/14 21:27:13 Done.
+ uint64 id,
+ chrome::MediaGalleriesPreferences* preferences);
// Called when the list of known galleries has changed; updates the page.
void OnGalleriesChanged();
+ void OnGalleriesChangedWithPreferences(
+ chrome::MediaGalleriesPreferences* preferences);
+
+ void FileSelectedWithPreferences(
+ base::FilePath path,
+ chrome::MediaGalleriesPreferences* preferences);
+
PrefChangeRegistrar pref_change_registrar_;
scoped_refptr<ui::SelectFileDialog> select_file_dialog_;
+ base::WeakPtrFactory<MediaGalleriesHandler> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(MediaGalleriesHandler);
};

Powered by Google App Engine
This is Rietveld 408576698