chrome/browser/media_galleries/media_galleries_dialog_controller.cc - Issue 14556015: [Media Galleries] Lazily initialize the storage monitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_galleries_dialog_controller.cc

Issue 14556015: [Media Galleries] Lazily initialize the storage monitor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase on prefs Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/media_file_system_registry_unittest.cc ('K') | « chrome/browser/media_galleries/media_galleries_dialog_controller.h ('k') | chrome/browser/storage_monitor/test_storage_monitor.h » ('j') | chrome/browser/ui/webui/options/media_galleries_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_galleries_dialog_controller.cc

diff --git a/chrome/browser/media_galleries/media_galleries_dialog_controller.cc b/chrome/browser/media_galleries/media_galleries_dialog_controller.cc

index 56243441a859c7a2fbf6d1202add9d090952a82f..274e12fcc33458017fe0e29085364865eb9db149 100644

--- a/chrome/browser/media_galleries/media_galleries_dialog_controller.cc

+++ b/chrome/browser/media_galleries/media_galleries_dialog_controller.cc

@@ -99,10 +99,16 @@ MediaGalleriesDialogController::MediaGalleriesDialogController(

: web_contents_(web_contents),

extension_(&extension),

on_finish_(on_finish) {

+ StorageMonitor::GetInstance()->Initialize(base::Bind(

vandebo (ex-Chrome) 2013/05/23 15:04:17 nit: add a comment about why unretained is safe.

Greg Billock 2013/05/30 22:17:47 Done.

+ &MediaGalleriesDialogController::OnStorageMonitorInitialized,

+ base::Unretained(this)));

+void MediaGalleriesDialogController::OnStorageMonitorInitialized() {

MediaFileSystemRegistry* registry =

g_browser_process->media_file_system_registry();

preferences_ = registry->GetPreferences(

- Profile::FromBrowserContext(web_contents->GetBrowserContext()));

+ Profile::FromBrowserContext(web_contents_->GetBrowserContext()));

InitializePermissions();

dialog_.reset(MediaGalleriesDialog::Create(this));