[Media Galleries] Lazily initialize the storage monitor.

chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
@@ skipping 42 matching lines @@
 // Key for Media Gallery Permission Value.
 const char kMediaGalleryHasPermissionKey[] = "has_permission";
 
 // Handles the profile shutdown event on the file thread to clean up
 // GalleryWatchManager.
 void HandleProfileShutdownOnFileThread(void* profile_id) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
   GalleryWatchManager::OnProfileShutdown(profile_id);
 }
 
-// Gets the |gallery_file_path| and |gallery_pref_id| of the gallery specified
-// by the |gallery_id|. Returns true and set |gallery_file_path| and
-// |gallery_pref_id| if the |gallery_id| is valid and returns false otherwise.
-bool GetGalleryFilePathAndId(const std::string& gallery_id,
-                             Profile* profile,
-                             const Extension* extension,
-                             base::FilePath* gallery_file_path,
-                             chrome::MediaGalleryPrefId* gallery_pref_id) {
-  chrome::MediaGalleryPrefId pref_id;
-  if (!base::StringToUint64(gallery_id, &pref_id))
-    return false;
-  chrome::MediaFileSystemRegistry* registry =
-      g_browser_process->media_file_system_registry();
-   base::FilePath file_path(
-      registry->GetPreferences(profile)->LookUpGalleryPathForExtension(
-          pref_id, extension, false));
-  if (file_path.empty())
-    return false;
-  *gallery_pref_id = pref_id;
-  *gallery_file_path = file_path;
-  return true;
-}
-
 bool GetMediaGalleryPermissionFromDictionary(
     const DictionaryValue* dict,
     chrome::MediaGalleryPermission* out_permission) {
   std::string string_id;
   if (dict->GetString(kMediaGalleryIdKey, &string_id) &&
       base::StringToUint64(string_id, &out_permission->pref_id) &&
       dict->GetBoolean(kMediaGalleryHasPermissionKey,
                        &out_permission->has_permission)) {
     return true;
   }
@@ skipping 201 matching lines @@
 
 bool MediaGalleriesPrivateAddGalleryWatchFunction::RunImpl() {
   DCHECK(profile_);
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (!render_view_host() || !render_view_host()->GetProcess())
     return false;
 
   scoped_ptr<AddGalleryWatch::Params> params(
       AddGalleryWatch::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
-  base::FilePath gallery_file_path;
-  chrome::MediaGalleryPrefId gallery_pref_id = 0;
-  if (!GetGalleryFilePathAndId(params->gallery_id, profile_, GetExtension(),
-                               &gallery_file_path, &gallery_pref_id)) {
+
+  chrome::MediaGalleryPrefId pref_id = 0;

[Lei Zhang, 2013/05/14 04:12:23]

Use kInvalidMediaGalleryPrefId instead of 0?

[Greg Billock, 2013/05/14 21:27:13]

Done.

+  if (!base::StringToUint64(params->gallery_id, &pref_id) ||
+      pref_id == 0) {
     error_ = kInvalidGalleryIDError;
     return false;
   }
 
+  chrome::MediaFileSystemRegistry* registry =
+      g_browser_process->media_file_system_registry();
+  registry->GetPreferencesAsync(profile_,
+      base::Bind(&MediaGalleriesPrivateAddGalleryWatchFunction::OnPreferences,
+                 base::Unretained(this), pref_id));

[Lei Zhang, 2013/05/14 04:12:23]

MediaGalleriesPrivateAddGalleryWatchFunction is a AsyncExtensionFunction, which
is a UIThreadExtensionFunction, which is a ExtensionFunction, which is
RefCountedThreadSafe. Safer without Unretained()?

[Greg Billock, 2013/05/14 21:27:13]

Good point. Done.

+  return true;
+}
+
+void MediaGalleriesPrivateAddGalleryWatchFunction::OnPreferences(
+    chrome::MediaGalleryPrefId pref_id,
+    chrome::MediaGalleriesPreferences* preferences) {
+  base::FilePath file_path(preferences->LookUpGalleryPathForExtension(

[Lei Zhang, 2013/05/14 04:12:23]

Handle the case of an empty |file_path| like before this change?

[Greg Billock, 2013/05/14 21:27:13]

Oops! I thought I had maintained that, but it didn't make it.

+      pref_id, GetExtension(), false));
+
+  GalleryWatchStateTracker* state_tracker =
+      MediaGalleriesPrivateAPI::Get(profile_)->GetGalleryWatchStateTracker();
+  state_tracker->SetPreferences(preferences);
+
 #if defined(OS_WIN)
   MediaGalleriesPrivateEventRouter* router =
       MediaGalleriesPrivateAPI::Get(profile_)->GetEventRouter();
   DCHECK(router);
   content::BrowserThread::PostTaskAndReplyWithResult(
       content::BrowserThread::FILE,
       FROM_HERE,
       base::Bind(&GalleryWatchManager::SetupGalleryWatch,
                  profile_,
-                 gallery_pref_id,
-                 gallery_file_path,
+                 pref_id,
+                 file_path,
                  extension_id(),
                  router->AsWeakPtr()),
       base::Bind(&MediaGalleriesPrivateAddGalleryWatchFunction::HandleResponse,
                  this,
-                 gallery_pref_id));
+                 pref_id));
 #else
   // Recursive gallery watch operation is not currently supported on
   // non-windows platforms. Please refer to crbug.com/144491 for more details.
-  HandleResponse(gallery_pref_id, false);
+  HandleResponse(pref_id, false);
 #endif
-  return true;
 }
 
 void MediaGalleriesPrivateAddGalleryWatchFunction::HandleResponse(
     chrome::MediaGalleryPrefId gallery_id,
     bool success) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   extensions::api::media_galleries_private::AddGalleryWatchResult result;
   result.gallery_id = base::Uint64ToString(gallery_id);
   result.success = success;
   SetResult(result.ToValue().release());
@@ skipping 19 matching lines @@
 #if defined(OS_WIN)
   if (!render_view_host() || !render_view_host()->GetProcess())
     return false;
 
   // Remove gallery watch operation is currently supported on windows platforms.
   // Please refer to crbug.com/144491 for more details.
   scoped_ptr<RemoveGalleryWatch::Params> params(
       RemoveGalleryWatch::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
-  base::FilePath gallery_file_path;
-  chrome::MediaGalleryPrefId gallery_pref_id = 0;
-  if (!GetGalleryFilePathAndId(params->gallery_id, profile_, GetExtension(),
-                               &gallery_file_path, &gallery_pref_id)) {
+  chrome::MediaGalleryPrefId pref_id;
+  if (!base::StringToUint64(params->gallery_id, &pref_id) ||
+      pref_id == 0) {
     error_ = kInvalidGalleryIDError;
     return false;
   }
 
+  chrome::MediaFileSystemRegistry* registry =
+      g_browser_process->media_file_system_registry();
+  registry->GetPreferencesAsync(profile_, base::Bind(
+      &MediaGalleriesPrivateRemoveGalleryWatchFunction::OnPreferences,
+      base::Unretained(this), pref_id));
+  return true;
+}
+
+void MediaGalleriesPrivateRemoveGalleryWatchFunction::OnPreferences(
+    chrome::MediaGalleriesPreferences* preferences,
+    chrome::MediaGalleryPrefId pref_id) {
+  chrome::MediaGalleryPrefId gallery_pref_id = 0;
+  base::FilePath file_path(preferences->LookUpGalleryPathForExtension(

[Lei Zhang, 2013/05/14 04:12:23]

ditto

[Greg Billock, 2013/05/14 21:27:13]

Done.

+      pref_id, GetExtension(), false));
+
+  GalleryWatchStateTracker* state_tracker =
+      MediaGalleriesPrivateAPI::Get(profile_)->GetGalleryWatchStateTracker();
+  state_tracker->SetPreferences(preferences);
+
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE, FROM_HERE,
       base::Bind(&GalleryWatchManager::RemoveGalleryWatch,
                  profile_,
-                 gallery_file_path,
+                 preferences,
+                 file_path,
                  extension_id()));
 
   GalleryWatchStateTracker* state_tracker =
       MediaGalleriesPrivateAPI::Get(profile_)->GetGalleryWatchStateTracker();
-  state_tracker->OnGalleryWatchRemoved(extension_id(), gallery_pref_id);
+  state_tracker->OnGalleryWatchRemoved(extension_id(), pref_id);
 #endif
   return true;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 //              MediaGalleriesPrivateGetAllGalleryWatchFunction              //
 ///////////////////////////////////////////////////////////////////////////////
 
 MediaGalleriesPrivateGetAllGalleryWatchFunction::
 ~MediaGalleriesPrivateGetAllGalleryWatchFunction() {
@@ skipping 140 matching lines @@
     }
   }
 
   SetResult(result_list);
   SendResponse(true);
 
   return true;
 }
 
 }  // namespace extensions