[Media Galleries] Lazily initialize the storage monitor.

chrome/browser/media_galleries/media_file_system_registry_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MediaFileSystemRegistry unit tests.
 
 #include <algorithm>
 #include <set>
 
+#include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop.h"
 #include "base/run_loop.h"
 #include "base/stl_util.h"
 #include "base/stringprintf.h"
@@ skipping 264 matching lines @@
 
 class MediaFileSystemRegistryTest : public ChromeRenderViewHostTestHarness {
  public:
   MediaFileSystemRegistryTest();
   virtual ~MediaFileSystemRegistryTest() {}
 
   void CreateProfileState(size_t profile_count);
 
   ProfileState* GetProfileState(size_t i);
 
+  MediaGalleriesPreferences* GetPreferences(Profile* profile);
+
   base::FilePath empty_dir() {
     return empty_dir_;
   }
 
   base::FilePath dcim_dir() {
     return dcim_dir_;
   }
 
   TestMediaFileSystemContext* test_file_system_context() {
     return test_file_system_context_;
@@ skipping 71 matching lines @@
 #if defined OS_CHROMEOS
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
   chromeos::ScopedTestUserManager test_user_manager_;
 #endif
 
 // TODO(gbillock): Eliminate windows-specific code from this test.
 #if defined(OS_WIN)
   scoped_ptr<test::TestStorageMonitorWin> monitor_;
 #else
-  chrome::test::TestStorageMonitor monitor_;
+  scoped_ptr<chrome::test::TestStorageMonitor> monitor_;
 #endif
 
   MockProfileSharedRenderProcessHostFactory rph_factory_;
 
   ScopedVector<ProfileState> profile_states_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaFileSystemRegistryTest);
 };
 
 namespace {
@@ skipping 190 matching lines @@
   for (size_t i = 0; i < profile_count; ++i) {
     ProfileState* state = new ProfileState(&rph_factory_);
     profile_states_.push_back(state);
   }
 }
 
 ProfileState* MediaFileSystemRegistryTest::GetProfileState(size_t i) {
   return profile_states_[i];
 }
 
+MediaGalleriesPreferences* MediaFileSystemRegistryTest::GetPreferences(
+    Profile* profile) {
+  return GetMediaFileSystemRegistry()->GetPreferences(profile);

[vandebo (ex-Chrome), 2013/05/23 15:04:17]

Am I being dense? How is this different than just not overriding it?

[Greg Billock, 2013/05/30 22:17:47]

The test isn't a subclass -- it's just a convenience method to shorten some test
lines.

+}
+
 std::string MediaFileSystemRegistryTest::AddUserGallery(
     StorageInfo::Type type,
     const std::string& unique_id,
     const base::FilePath& path) {
   std::string device_id = StorageInfo::MakeDeviceId(type, unique_id);
   string16 name = path.LossyDisplayName();
   DCHECK(!StorageInfo::IsMediaDevice(device_id));
 
   for (size_t i = 0; i < profile_states_.size(); ++i) {
     profile_states_[i]->GetMediaGalleriesPrefs()->AddGalleryWithName(
@@ skipping 107 matching lines @@
       MediaFileSystemInfo info(path.LossyDisplayName(), path, std::string(),
                                0, std::string(), false, false);
       result.push_back(info);
     }
   }
   std::sort(result.begin(), result.end(), MediaFileSystemInfoComparator);
   return result;
 }
 
 void MediaFileSystemRegistryTest::SetUp() {
-#if defined(OS_WIN)
+#if !defined(OS_WIN)
+  monitor_.reset(new test::TestStorageMonitor());

[vandebo (ex-Chrome), 2013/05/23 15:04:17]

Put this in the #else clause.

Can use TestStoageMonitor on all platforms?

[Greg Billock, 2013/05/30 22:17:47]

The Win mock is for the MTP thing, which really should be in another test file,
not here. 

+  monitor_->Initialize(base::Bind(&base::DoNothing));
+  monitor_->MarkInitialized();
+  base::RunLoop().RunUntilIdle();
+#else
   test::TestPortableDeviceWatcherWin* portable_device_watcher =
       new test::TestPortableDeviceWatcherWin;
   test::TestVolumeMountWatcherWin* mount_watcher =
       new test::TestVolumeMountWatcherWin;
   portable_device_watcher->set_use_dummy_mtp_storage_info(true);
   monitor_.reset(new test::TestStorageMonitorWin(
       mount_watcher, portable_device_watcher));
-  monitor_->Init();
+  monitor_->Initialize(base::Bind(&base::DoNothing));
   // TODO(gbillock): Replace this with the correct event notification
   // on the storage monitor finishing the startup scan when that exists.
   base::RunLoop().RunUntilIdle();
   mount_watcher->FlushWorkerPoolForTesting();
   base::RunLoop().RunUntilIdle();
   mount_watcher->FlushWorkerPoolForTesting();
   base::RunLoop().RunUntilIdle();
 #endif
 
   ChromeRenderViewHostTestHarness::SetUp();
@@ skipping 101 matching lines @@
 
   // Attach a device.
   const std::string device_id = AttachDevice(
       StorageInfo::REMOVABLE_MASS_STORAGE_WITH_DCIM,
       "removable_dcim_fake_id",
       dcim_dir());
   EXPECT_EQ(gallery_count + 1, GetAutoAddedGalleries(profile_state).size());
 
   // Forget the device.
   bool forget_gallery = false;
-  MediaGalleriesPreferences* prefs =
-      GetMediaFileSystemRegistry()->GetPreferences(profile_state->profile());
+  MediaGalleriesPreferences* prefs = GetPreferences(profile_state->profile());
   const MediaGalleriesPrefInfoMap& galleries = prefs->known_galleries();
   for (MediaGalleriesPrefInfoMap::const_iterator it = galleries.begin();
        it != galleries.end(); ++it) {
     if (it->second.device_id == device_id) {
       prefs->ForgetGalleryById(it->first);
       forget_gallery = true;
       break;
     }
   }
   MessageLoop::current()->RunUntilIdle();
   EXPECT_TRUE(forget_gallery);
   EXPECT_EQ(gallery_count, GetAutoAddedGalleries(profile_state).size());
 
   // Call GetPreferences() and the gallery count should not change.
-  GetMediaFileSystemRegistry()->GetPreferences(profile_state->profile());
+  prefs = GetPreferences(profile_state->profile());
   EXPECT_EQ(gallery_count, GetAutoAddedGalleries(profile_state).size());
 }
 
 TEST_F(MediaFileSystemRegistryTest, GalleryNameDefault) {
   FSInfoMap galleries_info;
   InitForGalleriesInfoTest(&galleries_info);
 
   for (FSInfoMap::const_iterator it = galleries_info.begin();
        it != galleries_info.end();
        ++it) {
     CheckGalleryInfo(it->second, test_file_system_context(), &it->second.name,
                      it->second.path, false, false);
   }
 }
 
 // TODO(gbillock): Put the platform-specific parts of this test in tests
 // for those classes, not here. This test, internally, ends up creating an
-// MTP delegate.
+// MTP delegate. (Probably ./win/mtp_device_delegate_impl_win_unittest)
 #if !defined(OS_MACOSX)
 TEST_F(MediaFileSystemRegistryTest, GalleryNameMTP) {
   FSInfoMap galleries_info;
   InitForGalleriesInfoTest(&galleries_info);
 
 #if defined(OS_WIN)
   base::FilePath location(
       PortableDeviceWatcherWin::GetStoragePathFromStorageId(
           test::TestPortableDeviceWatcherWin::kStorageUniqueIdA));
 #else
@@ skipping 72 matching lines @@
   pref_info_with_relpath.device_id = device_id;
   EXPECT_EQ(dcim_dir().Append(pref_info_with_relpath.path).value(),
             pref_info_with_relpath.AbsolutePath().value());
 
   DetachDevice(device_id);
   EXPECT_TRUE(pref_info.AbsolutePath().empty());
   EXPECT_TRUE(pref_info_with_relpath.AbsolutePath().empty());
 }
 
 }  // namespace chrome