[Media Galleries] Lazily initialize the storage monitor.

chrome/browser/media_galleries/media_galleries_preferences.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
 
 #include "base/path_service.h"
 #include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
 #include "base/string16.h"
@@ skipping 601 matching lines @@
     MediaGalleryPrefId pref_id,
     bool has_permission) {
   // The gallery may not exist anymore if the user opened a second config
   // surface concurrently and removed it. Drop the permission update if so.
   MediaGalleriesPrefInfoMap::const_iterator gallery_info =
       known_galleries_.find(pref_id);
   if (gallery_info == known_galleries_.end())
     return;
 
 #if defined(ENABLE_EXTENSIONS)
   extensions::GalleryWatchStateTracker* state_tracker =

[vandebo (ex-Chrome), 2013/05/17 22:19:58]

Grr, this shouldn't be here... filed bug 241903

[Greg Billock, 2013/05/18 06:28:40]

We're using at least two mechanisms: the registry is using the prefs watcher to
look for changes, we have this direct plumbing. Perhaps we need an observer on
this class. :-/

[vandebo (ex-Chrome), 2013/05/20 15:45:46]

Actually three - This class already implements an observer, see
NotifyChangeObservers.

       extensions::GalleryWatchStateTracker::GetForProfile(profile_);
 #endif
   bool all_permission = HasAutoDetectedGalleryPermission(extension);
   if (has_permission && all_permission) {
     if (gallery_info->second.type == MediaGalleryPrefInfo::kAutoDetected) {
       extensions::MediaGalleriesPrivateAPI::UnsetMediaGalleryPermission(
           GetExtensionPrefs(), extension.id(), pref_id);
       NotifyChangeObservers(extension.id());
 #if defined(ENABLE_EXTENSIONS)
       if (state_tracker) {
         state_tracker->OnGalleryPermissionChanged(extension.id(), pref_id,
-                                                  true);
+                                                  true, this);
       }
 #endif
       return;
     }
   }
 
   if (!has_permission && !all_permission) {
     extensions::MediaGalleriesPrivateAPI::UnsetMediaGalleryPermission(
         GetExtensionPrefs(), extension.id(), pref_id);
   } else {
     extensions::MediaGalleriesPrivateAPI::SetMediaGalleryPermission(
         GetExtensionPrefs(), extension.id(), pref_id, has_permission);
   }
   NotifyChangeObservers(extension.id());
 #if defined(ENABLE_EXTENSIONS)
   if (state_tracker) {
     state_tracker->OnGalleryPermissionChanged(extension.id(), pref_id,
-                                              has_permission);
+                                              has_permission, this);
   }
 #endif
 }
 
 void MediaGalleriesPreferences::Shutdown() {
   weak_factory_.InvalidateWeakPtrs();
   profile_ = NULL;
 }
 
 // static
@@ skipping 15 matching lines @@
 }
 
 extensions::ExtensionPrefs*
 MediaGalleriesPreferences::GetExtensionPrefs() const {
   ExtensionService* extension_service =
       extensions::ExtensionSystem::Get(profile_)->extension_service();
   return extension_service->extension_prefs();
 }
 
 }  // namespace chrome