[Media Galleries] Lazily initialize the storage monitor.

chrome/browser/ui/webui/options/media_galleries_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/media_galleries_handler.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/media_galleries/media_file_system_registry.h"
 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/chrome_select_file_policy.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "content/public/browser/web_ui.h"
 #include "grit/generated_resources.h"
 
 namespace options {
 
 using chrome::MediaGalleriesPreferences;
 using chrome::MediaGalleriesPrefInfoMap;
 using chrome::MediaGalleryPrefInfo;
 
-MediaGalleriesHandler::MediaGalleriesHandler() {
+MediaGalleriesHandler::MediaGalleriesHandler()
+    : weak_ptr_factory_(this) {
 }
 
 MediaGalleriesHandler::~MediaGalleriesHandler() {
   if (select_file_dialog_.get())
     select_file_dialog_->ListenerDestroyed();
 }
 
 void MediaGalleriesHandler::GetLocalizedValues(DictionaryValue* values) {
   DCHECK(values);
 
@@ skipping 30 matching lines @@
       base::Bind(&MediaGalleriesHandler::HandleAddNewGallery,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "forgetGallery",
       base::Bind(&MediaGalleriesHandler::HandleForgetGallery,
                  base::Unretained(this)));
 }
 
 void MediaGalleriesHandler::OnGalleriesChanged() {
   Profile* profile = Profile::FromWebUI(web_ui());
-  chrome::MediaGalleriesPreferences* preferences =
-      g_browser_process->media_file_system_registry()->GetPreferences(profile);
+      g_browser_process->media_file_system_registry()->GetPreferencesAsync(
+          profile,
+          base::Bind(&MediaGalleriesHandler::OnGalleriesChangedWithPreferences,
+                     weak_ptr_factory_.GetWeakPtr()));
+}
 
+void MediaGalleriesHandler::OnGalleriesChangedWithPreferences(
+    chrome::MediaGalleriesPreferences* preferences) {
   ListValue list;
   const MediaGalleriesPrefInfoMap& galleries = preferences->known_galleries();
   for (MediaGalleriesPrefInfoMap::const_iterator iter = galleries.begin();
        iter != galleries.end(); ++iter) {
     const MediaGalleryPrefInfo& gallery = iter->second;
     if (gallery.type == MediaGalleryPrefInfo::kBlackListed)
       continue;
 
     DictionaryValue* dict = new DictionaryValue();
     dict->SetString("displayName", gallery.display_name);
     dict->SetString("path", gallery.AbsolutePath().LossyDisplayName());
     dict->SetString("id", base::Uint64ToString(gallery.pref_id));
     list.Append(dict);
   }
 
   web_ui()->CallJavascriptFunction(

[vandebo (ex-Chrome), 2013/05/16 18:56:27]

Is it ok to do this asynchronously ?

[Lei Zhang, 2013/05/16 21:09:12]

Most browser <-> renderer communication is async.

[vandebo (ex-Chrome), 2013/05/17 22:19:58]

'doh - right.

       "options.MediaGalleriesManager.setAvailableMediaGalleries", list);
 }
 
 void MediaGalleriesHandler::HandleAddNewGallery(const base::ListValue* args) {
   select_file_dialog_ = ui::SelectFileDialog::Create(
       this,
       new ChromeSelectFilePolicy(web_ui()->GetWebContents()));
   select_file_dialog_->SelectFile(
       ui::SelectFileDialog::SELECT_FOLDER,
       string16(),  // TODO(estade): a name for the dialog?
       base::FilePath(),
       NULL, 0,
       base::FilePath::StringType(),
       web_ui()->GetWebContents()->GetView()->
           GetTopLevelNativeWindow(),
       NULL);
 }
 
 void MediaGalleriesHandler::HandleForgetGallery(const base::ListValue* args) {
   std::string string_id;
   uint64 id = 0;
   if (!args->GetString(0, &string_id) ||
       !base::StringToUint64(string_id, &id)) {
     NOTREACHED();
     return;
   }
 
-  chrome::MediaGalleriesPreferences* prefs =
-      g_browser_process->media_file_system_registry()->GetPreferences(
-          Profile::FromWebUI(web_ui()));
-  prefs->ForgetGalleryById(id);
+  g_browser_process->media_file_system_registry()->GetPreferencesAsync(
+      Profile::FromWebUI(web_ui()),
+      base::Bind(&MediaGalleriesHandler::HandleForgetGalleryWithPreferences,
+                 weak_ptr_factory_.GetWeakPtr(), id));
+}
+
+void MediaGalleriesHandler::HandleForgetGalleryWithPreferences(
+    uint64 id,
+    chrome::MediaGalleriesPreferences* preferences) {
+  preferences->ForgetGalleryById(id);
 }
 
 void MediaGalleriesHandler::FileSelected(const base::FilePath& path,
                                          int index,
                                          void* params) {
-  chrome::MediaGalleriesPreferences* prefs =
-      g_browser_process->media_file_system_registry()->GetPreferences(
-          Profile::FromWebUI(web_ui()));
-  prefs->AddGalleryByPath(path);
+  g_browser_process->media_file_system_registry()->GetPreferencesAsync(
+      Profile::FromWebUI(web_ui()),
+      base::Bind(&MediaGalleriesHandler::FileSelectedWithPreferences,
+                 weak_ptr_factory_.GetWeakPtr(), path));
+}
+
+void MediaGalleriesHandler::FileSelectedWithPreferences(
+    base::FilePath path,
+    chrome::MediaGalleriesPreferences* preferences) {
+  preferences->AddGalleryByPath(path);
 }
 
 }  // namespace options