Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 14556002: Uses slt and sltu for signed vs. unsigned comparison by the MIPS assembler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_mips.cc
===================================================================
--- runtime/vm/intermediate_language_mips.cc (revision 22132)
+++ runtime/vm/intermediate_language_mips.cc (working copy)
@@ -1026,7 +1026,7 @@
Label* deopt = compiler->AddDeoptStub(deopt_id(), kDeoptInt32Load);
__ lw(result, element_address);
// Verify that the signed value in 'result' can fit inside a Smi.
- __ BranchLess(result, 0xC0000000, deopt);
+ __ BranchSignedLess(result, 0xC0000000, deopt);
__ SmiTag(result);
}
break;
@@ -1735,7 +1735,7 @@
__ LoadImmediate(TMP1, Isolate::Current()->stack_limit_address());
__ lw(TMP1, Address(TMP1));
- __ BranchLessEqual(SP, TMP1, slow_path->entry_label());
+ __ BranchUnsignedLessEqual(SP, TMP1, slow_path->entry_label());
__ Bind(slow_path->exit_label());
}
@@ -2299,18 +2299,18 @@
Register length = locs()->in(0).reg();
const Object& constant = locs()->in(1).constant();
ASSERT(constant.IsSmi());
- __ BranchLessEqual(length, reinterpret_cast<int32_t>(constant.raw()),
- deopt);
+ __ BranchUnsignedLessEqual(
+ length, reinterpret_cast<int32_t>(constant.raw()), deopt);
} else if (locs()->in(0).IsConstant()) {
ASSERT(locs()->in(0).constant().IsSmi());
const Smi& smi_const = Smi::Cast(locs()->in(0).constant());
Register index = locs()->in(1).reg();
- __ BranchGreaterEqual(index, reinterpret_cast<int32_t>(smi_const.raw()),
- deopt);
+ __ BranchUnsignedGreaterEqual(
+ index, reinterpret_cast<int32_t>(smi_const.raw()), deopt);
} else {
Register length = locs()->in(0).reg();
Register index = locs()->in(1).reg();
- __ BranchGreaterEqual(index, length, deopt);
+ __ BranchUnsignedGreaterEqual(index, length, deopt);
}
}
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698