Uses slt and sltu for signed vs. unsigned comparison by the MIPS assembler.

runtime/vm/stub_code_mips.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_MIPS)
 
 #include "vm/assembler.h"
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
@@ skipping 268 matching lines @@
   // T2: address of first argument in array.
   Label loop, loop_condition;
   __ b(&loop_condition);
   __ Bind(&loop);
   __ lw(TMP, Address(T1));
   __ sw(TMP, Address(T2));
   __ AddImmediate(T1, -kWordSize);
   __ AddImmediate(T2, kWordSize);
   __ Bind(&loop_condition);
   __ AddImmediate(A1, -Smi::RawValue(1));  // A1 is Smi.
-  __ BranchGreaterEqual(A1, ZR, &loop);
+  __ BranchSignedGreaterEqual(A1, ZR, &loop);
 }
 
 
 // Input parameters:
 //   S5: ic-data.
 //   S4: arguments descriptor array.
 // Note: The receiver object is the first argument to the function being
 //       called, the stub accesses the receiver from this location directly
 //       when trying to resolve the call.
 void StubCode::GenerateInstanceFunctionLookupStub(Assembler* assembler) {
@@ skipping 213 matching lines @@
     __ addu(T2, T3, V0);
 
     // Check if the allocation fits into the remaining space.
     // V0: potential new object start.
     // A0: array element type.
     // A1: array length as Smi.
     // T0: points to new space object.
     // T2: potential next object start.
     // T3: array size.
     __ lw(TMP1, Address(T0, Scavenger::end_offset()));
-    __ BranchGreaterEqual(T2, TMP1, &slow_case);
+    __ BranchUnsignedGreaterEqual(T2, TMP1, &slow_case);
 
     // Successfully allocated the object(s), now update top to point to
     // next object start and initialize the object.
     // V0: potential new object start.
     // T2: potential next object start.
     // T0: Points to new space object.
     __ sw(T2, Address(T0, Scavenger::top_offset()));
     __ addiu(V0, V0, Immediate(kHeapObjectTag));
 
     // V0: new object start as a tagged pointer.
@@ skipping 265 matching lines @@
 
   // Set up arguments for the Dart call.
   Label push_arguments;
   Label done_push_arguments;
   __ beq(T1, ZR, &done_push_arguments);  // check if there are arguments.
   __ mov(A1, ZR);
   __ Bind(&push_arguments);
   __ lw(A3, Address(A2));
   __ Push(A3);
   __ addiu(A1, A1, Immediate(1));
-  __ BranchLess(A1, T1, &push_arguments);
+  __ BranchSignedLess(A1, T1, &push_arguments);
   __ delay_slot()->addiu(A2, A2, Immediate(kWordSize));
 
   __ Bind(&done_push_arguments);
 
   // Call the Dart code entrypoint.
   __ jalr(A0);  // S4 is the arguments descriptor array.
   __ TraceSimMsg("InvokeDartCodeStub return");
 
   // Read the saved new Context pointer.
   __ lw(CTX, Address(FP, kNewContextOffset));
@@ skipping 58 matching lines @@
     // Check if the allocation fits into the remaining space.
     // V0: potential new object.
     // T1: number of context variables.
     // T2: object size.
     // T3: potential next object start.
     __ LoadImmediate(TMP1, heap->EndAddress());
     __ lw(TMP1, Address(TMP1, 0));
     if (FLAG_use_slow_path) {
       __ b(&slow_case);
     } else {
-      __ BranchGreaterEqual(T3, TMP1, &slow_case);
+      __ BranchUnsignedGreaterEqual(T3, TMP1, &slow_case);
     }
 
     // Successfully allocated the object, now update top to point to
     // next object start and initialize the object.
     // V0: new object.
     // T1: number of context variables.
     // T2: object size.
     // T3: next object start.
     __ sw(T3, Address(T5, 0));
     __ addiu(V0, V0, Immediate(kHeapObjectTag));
@@ skipping 173 matching lines @@
       // InstantiatedTypeArguments object start.
     }
     // Check if the allocation fits into the remaining space.
     // T2: potential new object start.
     // T3: potential next object start.
     __ LoadImmediate(TMP1, heap->EndAddress());
     __ lw(TMP1, Address(TMP1));
     if (FLAG_use_slow_path) {
       __ b(&slow_case);
     } else {
-      __ BranchGreaterEqual(T3, TMP1, &slow_case);
+      __ BranchUnsignedGreaterEqual(T3, TMP1, &slow_case);
     }
 
     // Successfully allocated the object(s), now update top to point to
     // next object start and initialize the object.
     __ sw(T3, Address(T5));
 
     if (is_cls_parameterized) {
       // Initialize the type arguments field in the object.
       // T2: new object start.
       // T4: potential new object end and, if T4 != T3, potential new
@@ skipping 55 matching lines @@
       __ addiu(T4, T2, Immediate(sizeof(RawObject)));
       // Loop until the whole object is initialized.
       // T0: raw null.
       // T2: new object.
       // T3: next object start.
       // T4: next word to be initialized.
       // T1: new object type arguments (if is_cls_parameterized).
       Label init_loop;
       Label done;
       __ Bind(&init_loop);
-      __ BranchGreaterEqual(T4, T3, &done);  // Done if T4 >= T3.
+      __ BranchUnsignedGreaterEqual(T4, T3, &done);  // Done if T4 >= T3.
       __ sw(T0, Address(T4));
       __ AddImmediate(T4, kWordSize);
       __ b(&init_loop);
       __ Bind(&done);
     }
     if (is_cls_parameterized) {
       // R1: new object type arguments.
       // Set the type arguments in the new object.
       __ sw(T1, Address(T2, cls.type_arguments_field_offset()));
     }
@@ skipping 74 matching lines @@
     }
     // Check if the allocation fits into the remaining space.
     // T2: potential new closure object.
     // T3: address of top of heap.
     // T4: potential new context object (only if is_implicit_closure).
     __ LoadImmediate(TMP1, heap->EndAddress());
     __ lw(TMP1, Address(TMP1));
     if (FLAG_use_slow_path) {
       __ b(&slow_case);
     } else {
-      __ BranchGreaterEqual(T3, TMP1, &slow_case);
+      __ BranchUnsignedGreaterEqual(T3, TMP1, &slow_case);
     }
 
     // Successfully allocated the object, now update top to point to
     // next object start and initialize the object.
     __ sw(T3, Address(T5));
 
     // T2: new closure object.
     // T4: new context object (only if is_implicit_closure).
     // Set the tags.
     uword tags = 0;
@@ skipping 132 matching lines @@
     __ lw(S4, Address(SP, 2 * kWordSize));  // Restore.
     __ lw(S5, Address(SP, 3 * kWordSize));
     __ lw(T0, Address(SP, 4 * kWordSize));
     __ addiu(SP, SP, Immediate(5 * kWordSize));  // Discard argument;
     __ LeaveStubFrame();
   }
   __ lw(T7, FieldAddress(func_reg, Function::usage_counter_offset()));
   Label is_hot;
   if (FlowGraphCompiler::CanOptimize()) {
     ASSERT(FLAG_optimization_counter_threshold > 1);
-    __ BranchGreaterEqual(T7, FLAG_optimization_counter_threshold, &is_hot);
+    __ BranchSignedGreaterEqual(T7, FLAG_optimization_counter_threshold,
+                                &is_hot);
     // As long as VM has no OSR do not optimize in the middle of the function
     // but only at exit so that we have collected all type feedback before
     // optimizing.
   }
   __ addiu(T7, T7, Immediate(1));
   __ sw(T7, FieldAddress(func_reg, Function::usage_counter_offset()));
   __ Bind(&is_hot);
 }
 
 
@@ skipping 699 matching lines @@
   __ Bind(&done);
   __ lw(T0, Address(SP, 0 * kWordSize));
   __ lw(T1, Address(SP, 1 * kWordSize));
   __ Ret();
   __ delay_slot()->addiu(SP, SP, Immediate(2 * kWordSize));
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_MIPS