Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1455563005: PPC: Handle StepIn for constructors through PrepareStep just like for regular calls (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Handle StepIn for constructors through PrepareStep just like for regular calls Port 14ec485c3a2887af22e17fb3906215d9a02f5e83 R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/fc4c55108d0c75a6f32e5ad180eacfe745df4e06 Cr-Commit-Position: refs/heads/master@{#32060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -32 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +0 lines, -22 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-17 17:47:07 UTC) #1
JoranSiu
On 2015/11/17 17:47:07, mtbrandyberry wrote: lgtm
5 years, 1 month ago (2015-11-17 19:39:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455563005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455563005/1
5 years, 1 month ago (2015-11-17 19:43:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 20:02:57 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 20:03:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc4c55108d0c75a6f32e5ad180eacfe745df4e06
Cr-Commit-Position: refs/heads/master@{#32060}

Powered by Google App Engine
This is Rietveld 408576698