Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h

Issue 145553009: rAc: use libaddressinput to validate international addresses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h
diff --git a/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h b/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h
index a23684d1a04edf64016bec8fd96d103fbd159d8d..edd203e6d08a5c018ea99d6d283e89b10493b346 100644
--- a/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h
+++ b/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h
@@ -86,12 +86,13 @@ class AddressValidator {
virtual ~AddressValidator();
- // Builds an address validator. Takes ownership of |downloader| and |storage|,
- // which cannot be NULL. Does not take ownership of |load_rules_delegate|,
- // which can be NULL. The caller owns the result.
+ // Builds an address validator. Takes ownership of |downloader|. Does not take
+ // ownership of |storage| nor downloader |load_rules_delegate|. |storage| must
+ // outlive this class and both |downloader| and |storage| must be non-NULL.
+ // Caller owns the result.
static scoped_ptr<AddressValidator> Build(
scoped_ptr<Downloader> downloader,
- scoped_ptr<Storage> storage,
+ Storage* storage,
Evan Stade 2014/01/27 23:11:15 revert
Dan Beam 2014/01/28 02:22:36 Done.
LoadRulesDelegate* load_rules_delegate);
// Loads the generic validation rules for |country_code| and specific rules

Powered by Google App Engine
This is Rietveld 408576698