Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145553004: isolate.py: right command is 'archive', not 'hashtable'. (Closed)

Created:
6 years, 11 months ago by M-A Ruel
Modified:
6 years, 11 months ago
CC:
chromium-reviews, stip+watch_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

isolate.py: right command is 'archive', not 'hashtable'. This is important because the behavior for hashtable will be changed soon. The archive command has been an alias for hashtable since r222953 (2013-09-13) so it is safe to change. Update all references to test_isolation_mode=hashtable to test_isolation_mode=archive. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247269

Patch Set 1 #

Patch Set 2 : Trained #

Patch Set 3 : Also fix 2 test_isolation_mode=hashtable references #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M scripts/master/factory/commands.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/master/factory/swarm_factory.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/isolate/api.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_blink.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_tryserver.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_blink.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_git.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_checkout.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver_blink.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_blink.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/linux_release.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_release.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
6 years, 11 months ago (2014-01-23 18:07:28 UTC) #1
iannucci
On 2014/01/23 18:07:28, M-A Ruel wrote: Please re-train the test expectations by running `scripts/slave/unittests/recipes_test.py --train` ...
6 years, 11 months ago (2014-01-23 19:42:50 UTC) #2
M-A Ruel
On 2014/01/23 19:42:50, iannucci wrote: > On 2014/01/23 18:07:28, M-A Ruel wrote: > > Please ...
6 years, 11 months ago (2014-01-24 13:45:20 UTC) #3
Ken Russell (switch to Gerrit)
Thanks for this fix. LGTM
6 years, 11 months ago (2014-01-24 23:15:42 UTC) #4
iannucci
lgtm as well. kbr/M-A one of you should CQ since I'm out of time-zone-sync.
6 years, 11 months ago (2014-01-25 16:57:14 UTC) #5
Ken Russell (switch to Gerrit)
On 2014/01/25 16:57:14, iannucci wrote: > lgtm as well. kbr/M-A one of you should CQ ...
6 years, 11 months ago (2014-01-27 02:10:32 UTC) #6
M-A Ruel
On 2014/01/27 02:10:32, Ken Russell wrote: > On 2014/01/25 16:57:14, iannucci wrote: > > lgtm ...
6 years, 11 months ago (2014-01-27 02:55:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/145553004/130001
6 years, 11 months ago (2014-01-27 18:08:35 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-27 18:10:09 UTC) #9
Message was sent while issue was closed. 
Change committed as 247269

Powered by Google App Engine
This is Rietveld 408576698