Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1455503003: dart2js cps: Update status file. (Closed)

Created:
5 years, 1 month ago by asgerf
Modified:
5 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Update status file. These used to fail with an assertion error about GlobalEventHandlers, but not anymore. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/44a200b88de6f0a5f8cca87552b0871520721a18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 1 month ago (2015-11-17 14:20:05 UTC) #2
Johnni Winther
lgtm
5 years, 1 month ago (2015-11-17 14:22:10 UTC) #3
asgerf
5 years, 1 month ago (2015-11-17 14:23:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44a200b88de6f0a5f8cca87552b0871520721a18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698