Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 14555009: Remove [NoInterfaceObject] from several WebAudio IDL interfaces (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Remove [NoInterfaceObject] from several WebAudio IDL interfaces Several WebAudio IDL interfaces had [NoInterfaceObject] extended attribute set, meaning that there was no corresponding attribute on the global window object. This behavior is not according to the specification: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html This patch removes the [NoInterfaceObject] extended attribute where needed to match the specification. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 9 chunks +21 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AnalyserNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioBuffer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioDestinationNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioListener.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioParam.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/BiquadFilterNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/ChannelMergerNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/ChannelSplitterNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/ConvolverNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/DelayNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/DynamicsCompressorNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/GainNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/MediaStreamAudioDestinationNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/MediaStreamAudioSourceNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/OscillatorNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/WaveShaperNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/WaveTable.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-10 12:56:00 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 7 months ago (2013-05-10 13:54:06 UTC) #2
haraken
LGTM2
7 years, 7 months ago (2013-05-10 13:58:36 UTC) #3
Chris Rogers
lgtm - guess this was just a mistake from a couple days ago?
7 years, 7 months ago (2013-05-10 18:56:00 UTC) #4
do-not-use
On 2013/05/10 18:56:00, Chris Rogers wrote: > lgtm - guess this was just a mistake ...
7 years, 7 months ago (2013-05-10 23:54:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14555009/1
7 years, 7 months ago (2013-05-10 23:55:27 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7526
7 years, 7 months ago (2013-05-11 01:04:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14555009/1
7 years, 7 months ago (2013-05-11 16:28:12 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-11 16:55:05 UTC) #9
Message was sent while issue was closed.
Change committed as 150168

Powered by Google App Engine
This is Rietveld 408576698