Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1455423002: Revert of Define MOJO_SHELL_CLIENT uniformly across content (Closed)

Created:
5 years, 1 month ago by Ben Goodger (Google)
Modified:
5 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Define MOJO_SHELL_CLIENT uniformly across content (patchset #3 id:40001 of https://codereview.chromium.org/1462753002/ ) Reason for revert: Not needed. Original issue's description: > Define MOJO_SHELL_CLIENT uniformly across content > > Separated out of https://codereview.chromium.org/1452823003/ > > TBR=jam@chromium.org > http://crbug.com/551253 > > Committed: https://crrev.com/5e739169f376c3bf9c2c35a4efa0ebb6cbb3a9ee > Cr-Commit-Position: refs/heads/master@{#360514} TBR=jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/02a377770e28b7b6129435d2eb27d38ac53dd619 Cr-Commit-Position: refs/heads/master@{#360522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -46 lines) Patch
M content/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M content/utility/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
Created Revert of Define MOJO_SHELL_CLIENT uniformly across content
5 years, 1 month ago (2015-11-19 04:34:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455423002/1
5 years, 1 month ago (2015-11-19 04:35:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 04:37:13 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 04:38:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02a377770e28b7b6129435d2eb27d38ac53dd619
Cr-Commit-Position: refs/heads/master@{#360522}

Powered by Google App Engine
This is Rietveld 408576698