Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1455413002: Make some editing layout test files to use w3c test harness (Closed)

Created:
5 years, 1 month ago by yosin_UTC9
Modified:
5 years, 1 month ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make some editing layout test files to use w3c test harness This patch makes following tests to use w3c test harness to simplify tests and reduce flakiness. This patch is a preparation of getting rid of synchronous code path for spellcheck. BUG=295722 TEST=n/a; no behavior changes Committed: https://crrev.com/428cf58f0aa4848617963cadabba117dfe097c64 Cr-Commit-Position: refs/heads/master@{#360530}

Patch Set 1 : 2015-11-19T12:41:19 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -39 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/5354455-1.html View 2 chunks +12 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/5354455-1-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/5497643.html View 1 chunk +9 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/5497643-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
5 years, 1 month ago (2015-11-19 05:04:11 UTC) #4
hajimehoshi
lgtm
5 years, 1 month ago (2015-11-19 05:09:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455413002/1
5 years, 1 month ago (2015-11-19 05:17:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 05:34:22 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 05:35:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/428cf58f0aa4848617963cadabba117dfe097c64
Cr-Commit-Position: refs/heads/master@{#360530}

Powered by Google App Engine
This is Rietveld 408576698