Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1455403004: Use std::tie() for operator< in storage/ (Closed)

Created:
5 years, 1 month ago by jsbell
Modified:
5 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::tie() for operator< in storage/ Simplify the code for operator< when comparing multiple members using a common std::tie idiom. BUG=555171 R=danakj@chromium.org Committed: https://crrev.com/88d282b32742c2208b5e470a8f7f88526a6badc7 Cr-Commit-Position: refs/heads/master@{#360873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M storage/browser/quota/quota_database.cc View 2 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jsbell
danakj@ - please take a look?
5 years, 1 month ago (2015-11-19 22:25:40 UTC) #1
danakj
LGTM
5 years, 1 month ago (2015-11-19 23:06:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455403004/1
5 years, 1 month ago (2015-11-19 23:08:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-20 00:30:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455403004/1
5 years, 1 month ago (2015-11-20 19:05:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 19:14:22 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 19:15:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88d282b32742c2208b5e470a8f7f88526a6badc7
Cr-Commit-Position: refs/heads/master@{#360873}

Powered by Google App Engine
This is Rietveld 408576698