Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3133)

Unified Diff: chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc

Issue 1455403003: Add an option to specify requested fields for fetching metadata. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleaned up. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc
diff --git a/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc b/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc
index 7ef074a33811959543ebf2bbf362c47e4813d5f6..f1ad803f5a3ca147b1d79ffc1c208ad7ef656ff6 100644
--- a/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc
+++ b/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc
@@ -26,6 +26,7 @@ namespace {
void GetFileInfoOnUIThread(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
+ int /* fields */,
const ProvidedFileSystemInterface::GetMetadataCallback& callback) {
util::FileSystemURLParser parser(url);
if (!parser.Parse()) {
@@ -34,6 +35,8 @@ void GetFileInfoOnUIThread(
return;
}
+ // TODO(mtomasz): Pass fields to FSP extensions so only requested fields are
+ // returned.
parser.file_system()->GetMetadata(
parser.file_path(),
ProvidedFileSystemInterface::METADATA_FIELD_DEFAULT,
@@ -317,14 +320,13 @@ void ProviderAsyncFileUtil::CreateDirectory(
void ProviderAsyncFileUtil::GetFileInfo(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
+ int fields,
const GetFileInfoCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- BrowserThread::PostTask(BrowserThread::UI,
- FROM_HERE,
- base::Bind(&GetFileInfoOnUIThread,
- base::Passed(&context),
- url,
- base::Bind(&OnGetFileInfo, callback)));
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&GetFileInfoOnUIThread, base::Passed(&context), url, fields,
+ base::Bind(&OnGetFileInfo, callback)));
}
void ProviderAsyncFileUtil::ReadDirectory(

Powered by Google App Engine
This is Rietveld 408576698