[InfoBars] Move links from tertiary buttons to links in the message.

[InfoBars] Move links from tertiary buttons to links in the message.

Concatenate any required links to the end of the InfoBar's main message
instead of showing them as tertiary buttons.

BUG=543205
Committed: https://crrev.com/04aa500ac2eaa915b46b2a3d9819a1e9604bb0d5
Cr-Commit-Position: refs/heads/master@{#360968}

[gone, 2015-11-19 01:52:23]

dfalcantara@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-11-19 21:05:06]

https://codereview.chromium.org/1455353002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java
(right):

https://codereview.chromium.org/1455353002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:148:
private CharSequence mMessageLinkText;
We should probably enforce that the link text is a plain old String.

https://codereview.chromium.org/1455353002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:620:
if (fullString.length() > 0) fullString.append(" ");
Languages like Chinese don't actually use space characters. We might want to use
a localized string here:

  <ph name="MESSAGE"><ex>An update is available.</ex>%1$s</ph> <ph
name="LINK">&lt;link&gt;%2$s&lt;/link&gt;<ex>Learn more</ex></ph>

[gone, 2015-11-20 23:40:57]

Seems like Hwi got the go ahead.

https://chromiumcodereview.appspot.com/1455353002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java
(right):

https://chromiumcodereview.appspot.com/1455353002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:148:
private CharSequence mMessageLinkText;
On 2015/11/19 21:05:06, newt wrote:
> We should probably enforce that the link text is a plain old String.

Done.

https://chromiumcodereview.appspot.com/1455353002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java:620:
if (fullString.length() > 0) fullString.append(" ");
On 2015/11/19 21:05:06, newt wrote:
> Languages like Chinese don't actually use space characters. We might want to
use
> a localized string here:
> 
>   <ph name="MESSAGE"><ex>An update is available.</ex>%1$s</ph> <ph
> name="LINK">&lt;link&gt;%2$s&lt;/link&gt;<ex>Learn more</ex></ph>

Sticking with a " " for now; it's just used as a separator between the message
and the link.

[newt (away), 2015-11-20 23:49:05]

lgtm

[gone, 2015-11-20 23:50:02]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-11-20 23:50:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455353002/40001

[commit-bot: I haz the power, 2015-11-21 00:49:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-21 00:49:55]

Patchset 3 (id:??) landed as
https://crrev.com/04aa500ac2eaa915b46b2a3d9819a1e9604bb0d5
Cr-Commit-Position: refs/heads/master@{#360968}