Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1455343002: Start calling show/hide onStart/onStop in DocumentActivity (Closed)

Created:
5 years, 1 month ago by Yusuf
Modified:
5 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start calling show/hide onStart/onStop in DocumentActivity This logic in documents diverge from CHromeActivity behavior for archaic reasons (crbug.com/451672). Making documents show/hide in the same time as all other ChromeActivities with this change. Verified that the previous bug that caused the bheavior divergence no longer exists after this CL. BUG=546182 Committed: https://crrev.com/e548d4580bbd915716a855f9195b6f5f2d63d2a1 Cr-Commit-Position: refs/heads/master@{#360581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTab.java View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yusuf
5 years, 1 month ago (2015-11-19 01:09:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455343002/1
5 years, 1 month ago (2015-11-19 01:11:04 UTC) #4
gone
lgtm
5 years, 1 month ago (2015-11-19 01:26:02 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 02:32:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455343002/1
5 years, 1 month ago (2015-11-19 15:02:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 15:06:24 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e548d4580bbd915716a855f9195b6f5f2d63d2a1 Cr-Commit-Position: refs/heads/master@{#360581}
5 years, 1 month ago (2015-11-19 15:07:38 UTC) #11
Yusuf
5 years ago (2015-11-24 00:05:01 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1464313003/ by yusufo@chromium.org.

The reason for reverting is: BUG=559197

This was causing an early tab.show call which made the test think the activity
is in the foreground.

Reverting my CL for now. Will have to figure out a proper way to hide/show to
reland..

Powered by Google App Engine
This is Rietveld 408576698