Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1455303003: Add a linear interpolation resampler. (Closed)

Created:
5 years, 1 month ago by johngro
Modified:
4 years, 10 months ago
Reviewers:
dalesat, jeffbrown
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@change6
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a linear interpolation resampler. Add a linear interpolation resampler to the motown audio service. BUG= Committed: https://chromium.googlesource.com/external/mojo/+/46ad38b88f4005432a63e499b77bf8953aa55d50

Patch Set 1 #

Patch Set 2 : rebase on top of samples_per_frame -> channels patchset #

Patch Set 3 : Rebased to a recent ToT #

Patch Set 4 : Final rebase before landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -6 lines) Patch
M services/media/audio/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/media/audio/platform/generic/mixer.cc View 2 chunks +11 lines, -1 line 0 comments Download
A + services/media/audio/platform/generic/mixers/linear_sampler.h View 3 chunks +5 lines, -5 lines 0 comments Download
A services/media/audio/platform/generic/mixers/linear_sampler.cc View 1 1 chunk +241 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
johngro
5 years, 1 month ago (2015-11-19 19:30:03 UTC) #2
johngro
Declaring code review bankruptcy on this CL. If there are still concerns, please feel free ...
4 years, 10 months ago (2016-01-28 22:11:49 UTC) #3
johngro
4 years, 10 months ago (2016-01-28 22:14:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
46ad38b88f4005432a63e499b77bf8953aa55d50.

Powered by Google App Engine
This is Rietveld 408576698