Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1455293004: Simplify MacroAssembler::InvokePrologue a bit. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify MacroAssembler::InvokePrologue a bit. This removes some dead code from the function invocation code when the arguments adaptor trampoline is called. This seems to be leftover code from when we used to support calling code objects directly. R=bmeurer@chromium.org Committed: https://crrev.com/adec2638606ea3929ca177cef3608ccf087ac4b6 Cr-Commit-Position: refs/heads/master@{#32126}

Patch Set 1 #

Patch Set 2 : Fix MIPS64 compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -103 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +1 line, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +1 line, -10 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 4 chunks +1 line, -10 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
Because dead code is best code.
5 years, 1 month ago (2015-11-19 16:00:17 UTC) #1
Benedikt Meurer
Nice. LGTM modulo test failures.
5 years, 1 month ago (2015-11-19 16:08:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455293004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455293004/20001
5 years, 1 month ago (2015-11-19 17:57:40 UTC) #5
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
5 years, 1 month ago (2015-11-19 19:37:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455293004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455293004/20001
5 years, 1 month ago (2015-11-19 19:43:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 19:44:54 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 19:45:13 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/adec2638606ea3929ca177cef3608ccf087ac4b6
Cr-Commit-Position: refs/heads/master@{#32126}

Powered by Google App Engine
This is Rietveld 408576698