Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1455273006: Make specialized SrcOver XPFactory (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make specialized SrcOver XPFactory BUG=skia: Committed: https://skia.googlesource.com/skia/+/a7006d45217d128a94fa53cb4b827cca79bc7049

Patch Set 1 #

Patch Set 2 : fix ctor #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -50 lines) Patch
M include/core/SkXfermode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/effects/GrCustomXfermode.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 4 chunks +47 lines, -4 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 6 chunks +110 lines, -29 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
egdaniel
5 years, 1 month ago (2015-11-20 14:42:47 UTC) #2
bsalomon
lgtm
5 years, 1 month ago (2015-11-20 14:54:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455273006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455273006/1
5 years, 1 month ago (2015-11-20 14:55:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/4387)
5 years, 1 month ago (2015-11-20 14:56:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455273006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455273006/20001
5 years, 1 month ago (2015-11-20 15:12:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/4315) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 15:13:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455273006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455273006/40001
5 years, 1 month ago (2015-11-20 15:18:29 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/a7006d45217d128a94fa53cb4b827cca79bc7049
5 years, 1 month ago (2015-11-20 22:01:10 UTC) #16
egdaniel
5 years, 1 month ago (2015-11-20 23:12:42 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1464933003/ by egdaniel@google.com.

The reason for reverting is: breaking some builds.

Powered by Google App Engine
This is Rietveld 408576698