Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1455273003: [heap] Enforce size checks in allocation stats. (Closed)

Created:
5 years, 1 month ago by Hannes Payer (out of office)
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Enforce size checks in allocation stats. This CL should be reverted after investigating the size chrasher. BUG=chromium:556912 LOG=n Committed: https://crrev.com/168293591111a381b26491407c3ccd16b800a168 Cr-Commit-Position: refs/heads/master@{#32119}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/heap/spaces.h View 1 4 chunks +11 lines, -7 lines 0 comments Download
M src/heap/spaces.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Hannes Payer (out of office)
5 years, 1 month ago (2015-11-19 10:55:37 UTC) #3
ulan
lgtm https://codereview.chromium.org/1455273003/diff/20001/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1455273003/diff/20001/src/heap/spaces.cc#newcode2710 src/heap/spaces.cc:2710: CHECK(limit() >= top()); CHECK_GE
5 years, 1 month ago (2015-11-19 12:36:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455273003/40001
5 years, 1 month ago (2015-11-19 14:23:38 UTC) #8
Hannes Payer (out of office)
https://codereview.chromium.org/1455273003/diff/20001/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1455273003/diff/20001/src/heap/spaces.cc#newcode2710 src/heap/spaces.cc:2710: CHECK(limit() >= top()); On 2015/11/19 12:36:10, ulan wrote: > ...
5 years, 1 month ago (2015-11-19 14:24:23 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-19 15:55:22 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 15:56:23 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/168293591111a381b26491407c3ccd16b800a168
Cr-Commit-Position: refs/heads/master@{#32119}

Powered by Google App Engine
This is Rietveld 408576698