chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js - Issue 1455223003: Stop ChromeVox Next page loading sounds when page finishes loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

Issue 1455223003: Stop ChromeVox Next page loading sounds when page finishes loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@active_indicator_next

Patch Set: Fixed focus changing and removing all tabs, addressed other feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/earcon_engine.js ('k') | chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

index a22726f2c4888eae344c40bb32f7214fae36a109..9d2a6b4b25fc13bdea8fb336afe8d4e68072ba32 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js

@@ -90,7 +90,6 @@ NextEarcons.prototype = {

this.engine_.cancelProgress();

break;

case cvox.Earcon.PAGE_START_LOADING:

- // TODO(dmazzoni): only when the page has focus.

this.engine_.startProgress();

break;

case cvox.Earcon.POP_UP_BUTTON:

@@ -116,5 +115,16 @@ NextEarcons.prototype = {

this.engine_.onWrap();

break;

}

- }

+ },

+ /**

+ * @override

+ */

+ cancelEarcon: function(earcon) {

+ switch (earcon) {

+ case cvox.Earcon.PAGE_START_LOADING:

+ this.engine_.cancelProgress();

+ break;

+ }

+ },

};