chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 1455223003: Stop ChromeVox Next page loading sounds when page finishes loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 1455223003: Stop ChromeVox Next page loading sounds when page finishes loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@active_indicator_next

Patch Set: Fixed focus changing and removing all tabs, addressed other feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/earcon_engine.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index 007b5bd686485f5c944391b33ada6b6fbf68d6b1..523e200d0959ad5b670da9a1f74dd328354a809d 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -627,6 +627,14 @@ Background.prototype = {

}

}.bind(this));

+ // If switching out of a ChromeVox Next mode, make sure we cancel

+ // the progress loading sound just in case.

+ if ((this.mode_ === ChromeVoxMode.NEXT ||

+ this.mode_ === ChromeVoxMode.FORCE_NEXT) &&

+ this.mode_ != mode) {

+ cvox.ChromeVox.earcons.cancelEarcon(cvox.Earcon.PAGE_START_LOADING);

+ }

this.mode_ = mode;