Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1455213006: [Not For Commit] Deferred building of PaintLayer filter-chain (Closed)

Created:
5 years, 1 month ago by fs
Modified:
5 years, 1 month ago
Reviewers:
Stephen White
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Not For Commit] Deferred building of PaintLayer filter-chain

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 6 chunks +28 lines, -11 lines 4 comments Download

Messages

Total messages: 3 (1 generated)
Stephen White
Thanks! I'll see if I can combine the best bits of your change and mine. ...
5 years, 1 month ago (2015-11-19 17:50:41 UTC) #2
fs
5 years, 1 month ago (2015-11-19 18:34:24 UTC) #3 
On 2015/11/19 at 17:50:41, senorblanco wrote:
> Thanks!
> 
> I'll see if I can combine the best bits of your change and mine.

Yepp, feel free to pick up anything that looks useful (and tests out ok of
course...)

https://codereview.chromium.org/1455213006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/1455213006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:2612:
removeFilterInfoIfNeeded();
On 2015/11/19 at 17:50:41, Stephen White wrote:
> Could you explain the rationale for this change?

Just based on the comment about "CSS shader files" (Custom Filters), which makes
it seem like a remnant that could be simplified.

https://codereview.chromium.org/1455213006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:2630: // TODO(fs): Could
check builder()->lastEffect() here to avoid rebuilding the filter chain.
On 2015/11/19 at 17:50:41, Stephen White wrote:
> It does seem to be unpleasant to be doing this on every call to
filterOutsets().

Indeed.

Powered by Google App Engine
This is Rietveld 408576698