Issue 1455213002: Handle potentially const interpolation

Issue 1455213002: Handle potentially const interpolation (Closed)

Created:
5 years, 1 month ago by hausner

Modified:
5 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Handle potentially const interpolation Fixes issue reported in 24970. As with all analysis for "potentially constant" expressions, this fix is too permissive. (See issue 392 for details.) BUG=24970 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/29e8118403f79cbe23a838776c1d132b53ca7ddb

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	runtime/vm/ast.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	runtime/vm/ast.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 5 (3 generated)

Ivan Posva

LGTM if the spec allows for interpolation to be const. -Ivan

5 years, 1 month ago (2015-11-19 06:54:54 UTC) #3

hausner

5 years ago (2015-11-30 22:37:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
29e8118403f79cbe23a838776c1d132b53ca7ddb (presubmit successful).