Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: chrome/browser/ui/views/location_bar/background_with_1_px_border.h

Issue 1455193003: Draw popup window toolbars as only containing a location bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@arbitrary_heights
Patch Set: Glass cleanups Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/background_with_1_px_border.h
diff --git a/chrome/browser/ui/views/location_bar/background_with_1_px_border.h b/chrome/browser/ui/views/location_bar/background_with_1_px_border.h
index 588b3f539883563561c65a614f3e82db3de5db7c..0d051b30d370151ecf29d2f19a5c94b27716ecd9 100644
--- a/chrome/browser/ui/views/location_bar/background_with_1_px_border.h
+++ b/chrome/browser/ui/views/location_bar/background_with_1_px_border.h
@@ -18,17 +18,11 @@ class View;
}
// BackgroundWith1PxBorder renders a solid background color, with a one pixel
-// border. This accounts for the scaling of the canvas, so that the border is
-// one pixel regardless of display scaling. When created for popup mode, the
-// border will be a rectangle, unless the window is maximized. A maximized popup
-// will remove the horizontal edges of the border.
-//
-// When created for non popups, the border will have rounded corners.
+// border with rounded corners. This accounts for the scaling of the canvas, so
+// that the border is one pixel regardless of display scaling.
class BackgroundWith1PxBorder : public views::Background {
public:
- BackgroundWith1PxBorder(SkColor background,
- SkColor border,
- bool is_popup_mode);
+ BackgroundWith1PxBorder(SkColor background, SkColor border);
void Paint(gfx::Canvas* canvas, views::View* view) const override;
@@ -36,11 +30,6 @@ class BackgroundWith1PxBorder : public views::Background {
// Color for the one pixel border.
SkColor border_color_;
- // If true the border will be a rectangle, and will not render the horizontal
- // edges when the window is maximized. If false the border will have rounded
- // corners.
- bool is_popup_mode_;
-
DISALLOW_COPY_AND_ASSIGN(BackgroundWith1PxBorder);
};
« no previous file with comments | « chrome/browser/ui/views/layout_constants.cc ('k') | chrome/browser/ui/views/location_bar/background_with_1_px_border.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698