Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1455163005: Implement AnalysisServer.getContainingContext() using ContextManager. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement AnalysisServer.getContainingContext() using ContextManager. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/abe8d87e0eb91fd1751ee715bd43bf6f5f8625fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -91 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +23 lines, -29 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 5 chunks +22 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 4 chunks +23 lines, -24 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 5 chunks +21 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-18 21:35:05 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-18 22:07:01 UTC) #2
scheglov
5 years, 1 month ago (2015-11-18 22:10:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
abe8d87e0eb91fd1751ee715bd43bf6f5f8625fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698