third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp - Issue 1455153003: Fix animation of 'color' w/ currentColor for SVG 'fill' and 'stroke'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

Issue 1455153003: Fix animation of 'color' w/ currentColor for SVG 'fill' and 'stroke' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/style/SVGComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

index e24a0d299506f74850f56787a3991ec2ef0e52b1..b8905ddb3a3e588a70d9235f1a1898dd85e8964e 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

@@ -92,8 +92,12 @@ static SVGPaintDescription requestPaint(const LayoutObject& object, const Comput

bool hasColor = false;

switch (paintType) {

case SVG_PAINTTYPE_CURRENTCOLOR:

- case SVG_PAINTTYPE_RGBCOLOR:

case SVG_PAINTTYPE_URI_CURRENTCOLOR:

+ // The keyword `currentcolor` takes its value from the value of the `color` property on the same element.

+ color = style.visitedDependentColor(CSSPropertyColor);

+ hasColor = true;

+ break;

+ case SVG_PAINTTYPE_RGBCOLOR:

case SVG_PAINTTYPE_URI_RGBCOLOR:

color = applyToFill ? svgStyle.fillPaintColor() : svgStyle.strokePaintColor();

hasColor = true;