third_party/WebKit/LayoutTests/svg/repaint/color-fill-currentColor-and-css.html - Issue 1455153003: Fix animation of 'color' w/ currentColor for SVG 'fill' and 'stroke'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/repaint/color-fill-currentColor-and-css.html

Issue 1455153003: Fix animation of 'color' w/ currentColor for SVG 'fill' and 'stroke' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: modify a test. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

	3 <script>

	4 window.testIsAsync = true;

	5

	6 function interval() {

	7 if (ani.currentTime >= 10 && ani.currentTime <= 20) {

	8 ani.pause();

	9 finishRepaintTest();

	10 }

	11 }

	12

	13 function repaintTest() {

	14 var circle = document.getElementsByTagName("circle")[0];

	15 ani = circle.animate([{ color: "blue" }, { color: "cyan"}], { duration: 2000 , iterations: 1});

	16 setInterval(interval, 1);
	fs 2015/12/15 15:34:57 Use requestAnimationFrame instead - or maybe runAf Use requestAnimationFrame instead - or maybe runAfterLayoutAndPaint. Or maybe setTimeout, update the animation there and then wait for a layout+paint. Something like: var ani = circle.animate(...); setTimeout(function() { ani.currentTime = ...; ani.pause(); runAfterLayoutAndPaint(finishRepaintTest); }, 0);
	17 }

	18 </script>

	19 <style>

	20 circle {

	21 fill: currentColor;

	22 color: blue;

	23 }

	24 </style>

	25 <body onload="runRepaintAndPixelTest()">
	fs 2015/12/15 15:34:57 I would prefer a ref-test if we really need to loo I would prefer a ref-test if we really need to look at what's painted (doesn't seem entirely unreasonable). For a repaint test hopefully runRepaintTest here is enough.
	26 <svg xmlns="http://www.w3.org/2000/svg" width=90 height=90>

	27 <circle r="40" cx="40" cy="40" />

	28 </svg>

	29 </body>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/repaint/color-fill-currentColor-and-css-expected.png » ('j') | no next file with comments »