Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2570)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1455143004: Use the window coordinate for the autofill bounds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index bcdc6afd7ffd6f940341e187fa8441af8f4225b3..a06e8d416374b22486944ab17d88f45a38d0be30 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -366,7 +366,7 @@ class DevToolsAgentTest : public RenderViewImplTest {
class RenderViewImplBlinkSettingsTest : public RenderViewImplTest {
public:
- void DoSetUp() {
+ virtual void DoSetUp() {
RenderViewImplTest::SetUp();
}
@@ -384,6 +384,22 @@ class RenderViewImplBlinkSettingsTest : public RenderViewImplTest {
void SetUp() override {}
};
+class RenderViewImplScaleFactorTest : public RenderViewImplBlinkSettingsTest {
+ public:
+ void DoSetUp() override {
+ RenderViewImplBlinkSettingsTest::DoSetUp();
+
+ ViewMsg_Resize_Params params;
+ params.screen_info.deviceScaleFactor = 2.f;
+ params.new_size = gfx::Size(100, 100);
+ params.physical_backing_size = gfx::Size(200, 200);
+ params.visible_viewport_size = params.new_size;
+ params.needs_resize_ack = false;
+ view()->OnResize(params);
+ ASSERT_EQ(2.f, view()->device_scale_factor_);
+ }
+};
+
// Ensure that the main RenderFrame is deleted and cleared from the RenderView
// after closing it.
TEST_F(RenderViewImplTest, RenderFrameClearedAfterClose) {
@@ -2471,6 +2487,29 @@ TEST_F(RenderViewImplBlinkSettingsTest, Negative) {
EXPECT_TRUE(settings()->viewportEnabled());
}
+TEST_F(RenderViewImplScaleFactorTest, ConverViewportToWindowWithoutZoomForDSF) {
+ DoSetUp();
+ blink::WebRect rect(20, 10, 200, 100);
+ view()->convertViewportToWindow(&rect);
+ EXPECT_EQ(20, rect.x);
+ EXPECT_EQ(10, rect.y);
+ EXPECT_EQ(200, rect.width);
+ EXPECT_EQ(100, rect.height);
+}
+
+TEST_F(RenderViewImplScaleFactorTest, ConverViewportToWindowWithZoomForDSF) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableUseZoomForDSF);
+ DoSetUp();
+
+ blink::WebRect rect(20, 10, 200, 100);
+ view()->convertViewportToWindow(&rect);
+ EXPECT_EQ(10, rect.x);
+ EXPECT_EQ(5, rect.y);
+ EXPECT_EQ(100, rect.width);
+ EXPECT_EQ(50, rect.height);
+}
+
TEST_F(DevToolsAgentTest, DevToolsResumeOnClose) {
Attach();
EXPECT_FALSE(IsPaused());

Powered by Google App Engine
This is Rietveld 408576698