Use the window coordinate for the autofill bounds.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 1923 matching lines @@
 
 // TODO(esprehn): Blink only ever passes Elements, this should take WebElement.
 void RenderViewImpl::focusedNodeChanged(const WebNode& fromNode,
                                         const WebNode& toNode) {
   has_scrolled_focused_editable_node_into_rect_ = false;
 
   gfx::Rect node_bounds;
   bool is_editable = false;
   if (!toNode.isNull() && toNode.isElementNode()) {
     WebElement element = const_cast<WebNode&>(toNode).to<WebElement>();
-    node_bounds = gfx::Rect(element.boundsInViewport());
+    if (IsUseZoomForDSFEnabled()) {
+      node_bounds = gfx::ScaleToEnclosedRect(
+          gfx::Rect(element.boundsInViewport()), 1 / device_scale_factor_);

[bokan, 2015/12/03 20:49:20]

If you change convertViewportToWindow to return a gfx::Rect you can use it here
too.

[oshima, 2015/12/03 21:58:17]

I was going to change this during cleanup but forgot to do so. Thank you for
pointing out. Done.

+    } else {
+      node_bounds = gfx::Rect(element.boundsInViewport());
+    }
     is_editable = element.isEditable();
   }
   Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, is_editable,
                                           node_bounds));
 
   // TODO(estade): remove.
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, FocusedNodeChanged(toNode));
 
   RenderFrameImpl* previous_frame = nullptr;
   if (!fromNode.isNull())
@@ skipping 174 matching lines @@
 
   SSLStatus result;
   CHECK(DeserializeSecurityInfo(security_info, &result));
   return result;
 }
 
 const std::string& RenderViewImpl::GetAcceptLanguages() const {
   return renderer_preferences_.accept_languages;
 }
 
+void RenderViewImpl::convertViewportToWindow(blink::WebRect* rect) {

[bokan, 2015/12/03 20:49:20]

Why not just make this return a gfx::Rect since Window coordinates are consumed
by the renderer which uses gfx::Rect (like in all your call-sites in this
patch)?

[oshima, 2015/12/03 21:58:17]

This was a part of larger CL, and Blink needs this for popup. See
https://codereview.chromium.org/1456753002/.

Is it ok to use gfx::Rect in WebWidgetClient? If not, we'll end up having two
almost identical but have slightly different signature on the same class.

I used out parameter because it may not have to update anything, but I'm happy
to return WebRect (or gfx::Rect). Please let me know.

[bokan, 2015/12/04 00:28:52]

Ah, I see. Yah, right now I think gfx::Rect is still disallowed in Source/web.
But with the repo merge I think it's something we should eliminate (as it is
now, WebRect is an extra intermediate step for no reason). I'll propose the
change on blink-dev. In the mean time, no need to block on that, lgtm as is and
we (I can do this) can change it later.

+  if (IsUseZoomForDSFEnabled()) {
+    float reverse = 1 / device_scale_factor_;
+    // TODO(oshima): We may wait to allow pixel precision here as the the
+    // anchor element can be placed at half pixel.
+    gfx::Rect window_rect =
+        gfx::ScaleToEnclosedRect(gfx::Rect(*rect), reverse);
+    rect->x = window_rect.x();
+    rect->y = window_rect.y();
+    rect->width = window_rect.width();
+    rect->height = window_rect.height();
+  }
+}
+
 void RenderViewImpl::didChangeIcon(WebLocalFrame* frame,
                                    WebIconURL::Type icon_type) {
   if (frame->parent())
     return;
 
   WebVector<WebIconURL> icon_urls = frame->iconURLs(icon_type);
   std::vector<FaviconURL> urls;
   for (size_t i = 0; i < icon_urls.size(); i++) {
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
@@ skipping 1571 matching lines @@
   if (IsUseZoomForDSFEnabled()) {
     compositor_->SetPaintedDeviceScaleFactor(device_scale_factor_);
     webview()->setZoomFactorForDeviceScaleFactor(
         device_scale_factor_);
   } else {
     webview()->setDeviceScaleFactor(device_scale_factor_);
   }
 }
 
 }  // namespace content